Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Cropping rendering problem #2373

Open
2 tasks done
DR-Univer opened this issue May 31, 2024 · 1 comment
Open
2 tasks done

[Bug] Cropping rendering problem #2373

DR-Univer opened this issue May 31, 2024 · 1 comment
Assignees
Labels
bug Something isn't working performance

Comments

@DR-Univer
Copy link
Collaborator

在您提交此问题之前,您是否检查了以下内容?

  • 这真的是个问题吗?
  • 我已经在 Github Issues 中搜索过了,但没有找到类似的问题。

受影响的包和版本

dev

复现链接

cache canvas应用了贴图之后,滚动不正确。
目前裁剪逻辑没有应用贴图缓存,性能比较差。
drawing-ui\src\views\crop\image-cropper-object.ts

image

操作路径

2024-05-31.183012.mp4

预期行为

高亮区域能够正确滚动

实际行为

高亮区域固定了,滚动后还保持了原来位置

运行环境

Chrome

系统信息

No response

@DR-Univer DR-Univer added bug Something isn't working performance labels May 31, 2024
@univer-bot univer-bot bot changed the title [Bug] 裁剪渲染问题 [Bug] Cropping rendering problem May 31, 2024
@univer-bot
Copy link

univer-bot bot commented May 31, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [Bug] 裁剪渲染问题

Title: [Bug] Cropping rendering problem


Before you submitted this question, did you check the following?

  • Is this really a problem?
  • I've searched Github Issues but haven't found any similar issues.

Affected packages and versions

dev

Recurrence link

After the texture is applied to the cache canvas, the scrolling is incorrect.
Currently, the cropping logic does not apply texture caching, and the performance is relatively poor.
drawing-ui\src\views\crop\image-cropper-object.ts

image

Operation path

2024-05-31.183012.mp4

Expected behavior

Highlighted areas scroll correctly

Actual behavior

The highlighted area is fixed and retains its original position after scrolling.

Running environment

Chrome

system message

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working performance
Projects
None yet
Development

No branches or pull requests

2 participants