feat(formula): add LEFT function implementation #2572
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dushusir
reviewed
Jun 21, 2024
| @@ -0,0 +1,151 @@ | |||
| /** | |||
There was a problem hiding this comment.
I suggest that the newly created feature branch should not carry the code of other feature branches, which will make the original feature branch useless. You can close the PR submitted by the source branch (such as #2547), or create a new branch from dev to develop the new function LEFT function
Dushusir
reviewed
Jun 21, 2024
| @@ -0,0 +1,170 @@ | |||
| /** | |||
sagarwal3005
pushed a commit
to sagarwal3005/univer
that referenced
this pull request
Jun 21, 2024
sagarwal3005
pushed a commit
to sagarwal3005/univer
that referenced
this pull request
Jun 21, 2024
sagarwal3005
force-pushed
the
feat/formula-left
branch
from
2bf97c1
to
ce979d5
Compare
Dushusir
reviewed
Jun 21, 2024
| expect(transformToValue(result.getArrayValue())).toStrictEqual([[ErrorType.VALUE]]); | ||
| }); | ||
|
|
||
| it('Extracts characters from array by specifying single numChar', () => { |
There was a problem hiding this comment.
Need support =LEFT("Univer",B3:B5)
View Deployment
|
sagarwal3005
force-pushed
the
feat/formula-left
branch
from
f6b36ba
to
d5d4195
Compare
sagarwal3005
requested review from
Jocs,
ybzky,
yuhongz,
Gggpound,
jikkai,
wzhudev,
hexf00 and
lumixraku
as code owners
|
This branch has synchronized the changes of other branches, and it is recommended to open a new branch for submission |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2558