Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request] Hold down ctrl to select multiple cells, then click to get cell information #2568

Open
2 tasks done
LaFee-Helei opened this issue Jun 20, 2024 · 2 comments
Assignees
Labels

Comments

@LaFee-Helei
Copy link

在您提交此问题之前,您是否检查了以下内容?

  • 这真的是个问题吗?
  • 我已经在 Github Issues 中搜索过了,但没有找到类似的问题。

受影响的包和版本

"@univerjs/core": "^0.1.15"

复现链接

https://univer.ai/playground?title=Vite

预期行为

const univerAPI = FUniver.newAPI(univer);
const activeWorkbook = univerAPI.getActiveWorkbook();
const activeSheet =activeWorkbook.getActiveSheet();
activeWorkbook.onSelectionChange((params)=>{
    console.log(params);
})

or

univerAPI.onCommandExecuted((command)=>{
    const { id, type, params } = command;
    if (id === 'sheet.operation.set-selections') {
        console.log(params);
    }
});

For example, I select two cells with ctrl, then hold down the ctrl key while clicking to get information about both cells

实际行为

Its selections add duplicate data with each operation
image
When a mouse click is performed, the same shee.Operation. set-selections command is triggered twice
image

运行环境

Safari

系统信息

No response

@LaFee-Helei LaFee-Helei added the bug Something isn't working label Jun 20, 2024
@univer-bot univer-bot bot changed the title Hold down ctrl to select multiple cells, then click to get cell information[Bug] Hold down ctrl to select multiple cells, then click to get cell information[Bug] Jun 20, 2024
@univer-bot
Copy link

univer-bot bot commented Jun 20, 2024

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [feature request] Hold down ctrl to select multiple cells, then click to get cell information

Title: [feature request] Hold down ctrl to select multiple cells, then click to get cell information


Before you submitted this question, did you check the following?

  • Is this really a problem?
  • I've searched Github Issues but haven't found any similar issues.

Affected packages and versions

"@univerjs/core": "^0.1.15"

Recurrence link

https://univer.ai/playground?title=Vite

Expected behavior

const univerAPI = FUniver.newAPI(univer);
const activeWorkbook = univerAPI.getActiveWorkbook();
const activeSheet =activeWorkbook.getActiveSheet();
activeWorkbook.onSelectionChange((params)=>{
    console.log(params);
})

or

univerAPI.onCommandExecuted((command)=>{
    const { id, type, params } = command;
    if (id === 'sheet.operation.set-selections') {
        console.log(params);
    }
});

For example, I select two cells with ctrl, then hold down the ctrl key while clicking to get information about both cells

Actual behavior

Its selections add duplicate data with each operation
image
When a mouse click is performed, the same shee.Operation. set-selections command is triggered twice
image

Running environment

Safari

System information

No response

@Dushusir Dushusir self-assigned this Jun 21, 2024
@Dushusir
Copy link
Member

Dushusir commented Jun 21, 2024

Repeated selection of a selection should require deselection instead of repeating it. This is not implemented yet, but compatibility with Excel will be considered in the future. @DR-Univer @lumixraku Please check it
selection

@Dushusir Dushusir assigned DR-Univer and unassigned Dushusir Jun 21, 2024
@Dushusir Dushusir added feature request New feature or request scope:selection and removed bug Something isn't working labels Jun 21, 2024
@wzhudev wzhudev assigned Dushusir and unassigned DR-Univer Jun 26, 2024
@lumixraku lumixraku changed the title Hold down ctrl to select multiple cells, then click to get cell information[Bug] [feature request] Hold down ctrl to select multiple cells, then click to get cell information Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants