HSL validation

[slashwhatever]

For color: hsl(12, 12%, 120)

The library classifies it as valid but Chrome and Firefox don't.

Edit: I have a PR ready to commit but I get an access denied when trying to create the pull request.

[dreamyguy]

Cheers for the heads up @slashwhatever. You'll need to clone the repo and create the pull request out of your cloned repo.

[slashwhatever]

Yea no worries - just having some issues with my public key for some reason. Will get it sorted and commit asap.

…

On Tue, 3 Mar 2020 at 08:58, Wallace Sidhrée ***@***.***> wrote: Cheers for the heads up @slashwhatever <https://github.com/slashwhatever>. You'll need to clone the repo and create the pull request out of your cloned repo. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#5?email_source=notifications&email_token=AAHTKOYVQVUW5F6DITIBSX3RFTBB7A5CNFSM4K7GSRBKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOENSUIYY#issuecomment-593839203>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHTKO7PREQHIMYLDN6JC63RFTBB7ANCNFSM4K7GSRBA> .

[dreamyguy]

Oh, I meant fork the repo, not clone.

[dreamyguy]

As I began my efforts on validating the upcoming CSS colors on #8, I chose to separate each color format into their own dedicated validation (all validations were contained in a single regular expression literal).

That led me to find quite a few problems with the HSL validation, that was quite weak.

I re-wrote it and now get the following (in relation to the former validation):

False positives (valid before, invalid now)

"rgb(-100, -10, 0 )"
"hsl(-100, -10, 0 )"
"hsl(1, 60%, 70)"
"hsl(100%, 100%, 100%)"
"hsl(12, 12%, 120)"
"hsla(100%, 100%, 100%, 1)"

False negatives (invalid before, valid now)

"hsl(180, 100%, 50%, 100%)"
"hsl(180deg, 100%, 50%)"
"hsl(180deg, 100%, 50%, 1)"
"hsl(180deg, 100%, 50%, 100%)"
"hsl(180 100% 50%)"
"hsl(180 100% 50% / 1)"
"hsl(180 100% 50% / 100%)"
"hsl(180deg 100% 50%)"
"hsl(180deg 100% 50% / 1)"
"hsl(180deg 100% 50% / 0.8)"
"hsl(180deg 100% 50% / .8)"
"hsl(180deg 100% 50% / 100%)"
"hsl(270 60% 70%)"
"hsl(270deg, 60%, 70%)"
"hsl(4.71239rad, 60%, 70%)"
"hsl(.75turn, 60%, 70%)"
"hsl(270, 60%, 50%, 15%)"
"hsl(270 60% 50% / .15)"
"hsl(270 60% 50% / 15%)"
"hsl(0deg, 60%, 70%)"
"hsl(1deg, 60%, 70%)"
"hsl(360deg, 60%, 70%)"
"hsl(0gra, 60%, 70%)"
"hsl(3gra, 60%, 70%)"
"hsl(120gra, 60%, 70%)"
"hsl(400gra, 60%, 70%)"
"hsl(0rad, 60%, 70%)"
"hsl(3rad, 60%, 70%)"
"hsl(5.29rad, 60%, 70%)"
"hsl(6.28rad, 60%, 70%)"
"hsl(.2turn, 60%, 70%)"
"hsl(.37turn, 60%, 70%)"
"hsl(.0turn, 60%, 70%)"
"hsl(0.0turn, 60%, 70%)"
"hsl(0.48turn, 60%, 70%)"
"hsl(1turn, 60%, 70%)"
"hsla(180, 100%, 50%, 100%)"
"hsla(180deg, 100%, 50%)"
"hsla(180deg, 100%, 50%, 1)"
"hsla(180deg, 100%, 50%, 100%)"
"hsla(180 100% 50%)"
"hsla(180 100% 50% / 1)"
"hsla(180 100% 50% / 100%)"
"hsla(180deg 100% 50%)"
"hsla(180deg 100% 50% / 1)"
"hsla(180deg 100% 50% / 0.8)"
"hsla(180deg 100% 50% / .8)"
"hsla(180deg 100% 50% / 100%)"

My changes are not pushed yet, but will be pushed by tomorrow. I'll mark this issue as solved, then.