Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation mistake #20

Closed
pandabamboo90 opened this issue Aug 10, 2019 · 1 comment · Fixed by #21
Closed

Documentation mistake #20

pandabamboo90 opened this issue Aug 10, 2019 · 1 comment · Fixed by #21
Assignees
@swilgosz

Comments

@pandabamboo90
Copy link

pandabamboo90 commented Aug 10, 2019 •
edited
Loading

Hi @swilgosz ,
Thanks for your great work on this gem.

I found the mistake in your documentation in the Custom errors mapping section, when I try to follow the docs.

This line

ErrorsMapper.map_errors! # Wrong class name

It should be

ErrorMapper.map_errors!
@swilgosz
Copy link
Member

Thank you fro reporting this @pandabamboo90 ! I'll fix it in a moment!

@swilgosz swilgosz self-assigned this Aug 10, 2019
swilgosz pushed a commit that referenced this issue Aug 10, 2019
Fix documentation for custom error mapping!
742b2cc 
Resolves #20
@swilgosz swilgosz mentioned this issue Aug 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@swilgosz swilgosz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix documentation for custom error mapping! driggl/jsonapi_errors_handler
2 participants
@pandabamboo90 @swilgosz