Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error object status member should be a string? #30

Closed
tibomogul opened this issue Jan 10, 2021 · 1 comment · Fixed by #39
Closed

Error object status member should be a string? #30

tibomogul opened this issue Jan 10, 2021 · 1 comment · Fixed by #39

Comments

@tibomogul
Copy link

According to the JSONAPI spec status: the HTTP status code applicable to this problem, expressed as a string value., though it is expressed as MAY. Should this be changed to a string? Happy to do a PR if needed.
@swilgosz
Copy link
Member

I think so. It's an overlook on my side - the generated JSON should match directly the docs. https://jsonapi.org/examples/#error-objects

It may be that we'll also need some improvements for the pointer part at some point. Thanks for checking that!

tibomogul added a commit to tibomogul/jsonapi_errors_handler that referenced this issue Jan 12, 2021
@tibomogul
Resolves driggl#30 Make error object's status a string
1546b3b 
force string as base

fix specs
@swilgosz swilgosz mentioned this issue Oct 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stringify error status driggl/jsonapi_errors_handler
2 participants
@tibomogul @swilgosz