-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PyPI release is not possible with direct references #160
Comments
|
I have a somewhat 🤨 idea regarding detectron2: What if we publish detectron2 to PyPI? We could either:
This will take a little work to maintain but should be mostly automateable with CI. If we do claim the detectron2 name, we could just be nice about releasing it back to FAIR if they ever change their mind about publishing to PyPI. |
I tried pip installing
|
It looks like yolox 0.2.0 (2022-01-17) had manylinux wheels on PyPI, which meant you could pip install without torch on Linux. However, yolox 0.3.0 (2022-04-22) went back to only having source distributions, so you have to build it when you install. |
We use direct references for
pytorchvideo
,densepose
, andyolox
in our requirements:zamba/setup.cfg
Line 37 in b4b706a
zamba/setup.cfg
Line 47 in b4b706a
zamba/setup.cfg
Line 64 in b4b706a
The official PyPI does not support direct references. Per PEP-440:
This means that we can't publish to PyPI until our dependencies are free of direct references. The best way to do so is to have maintainers of those packages publish on PyPI. Here's the current status:
pytorchvideo
has a recent release with the features we use. We can start using that immediately.yolox
has a PR open to make it specify dependencies properly. Once that is merged, there will need to be a separate request to publish as a package on PyPI.densepose
depdends ondetectron2
, which has a closed issue requesting it be made available on PyPI.Plan for now is to have documentation install from github, and to try to push the dependency packages forward to a happy resolution.
When fixing:
The text was updated successfully, but these errors were encountered: