Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Author Last,First displayed without comma #204

Open
onomou opened this issue Nov 19, 2020 · 1 comment
Open

Author Last,First displayed without comma #204

onomou opened this issue Nov 19, 2020 · 1 comment

Comments

@onomou
Copy link
Contributor

onomou commented Nov 19, 2020

The name of a question author or ancestor is displayed as Last,First without any space after the comma, as is the list of question ancestors. This appears in the question editor and question preview. I could not find any discussion about this, so here it is. I think it would be best to follow convention and put a space afterward.

Example:

MyOpenMath Commas

Places in the code I found this happen:

Calls that produce a list without spaces after the commas:

  • Sanitize::encodeStringForDisplay($line['author']))
  • Sanitize::encodeStringForDisplay($line['ancestors'])
  • Sanitize::encodeStringForDisplay($line['ancestorauthors'])
@drlippman
Copy link
Owner

The author name is stored that way in moddataset, line 554. Those other places are just displaying the stored value.

I agree it would be better with a space, but it would cause some challenges with matching previous author names to prevent duplicates when edits are made. But I might be able to work around that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants