SFX Player not running under OscarC

[adaumann]

Maybe that's not a topic for OscarC, but I have an issue with sound players. In this case from https://agpx.itch.io/sid-sfx-editor or a classic one called sfx-editor

In assembler it works out of the box but with OscarC the sound is somehow corrupted, playing the wrong tune or having unwanted loops etc. I also prepared the Zeropages (freed F8-FF) but no success. What could be the reason?

[drmortalwombat]

If you provide an example, I can take a look

[adaumann]

Here is the example: I have a sound file with player, starts at 0xC000. See attachment
sounds.zip. You can open it in the tool SIDSFX (see above). Also I added the ready player file sfx.prg. If you like to run it in assembler or basic:

Routine starts from 49152 and ends to 50238 (1087 bytes).

Usage:

In BASIC:

poke 54296,15: rem volume on

sys 49854: rem enable irq

poke 780,{sfx num.: 0 to 11}: poke 782,{voice num.: 0 to 2}: sys 49226: rem play sfx on a voice

poke 782,{voice num.: 0 to 2}: sys 49488: rem to stop a voice

peek(49870): rem equals to 0 when voice 0 ends (1 otherwise)
peek(49871): rem equals to 0 when voice 1 ends (1 otherwise)
peek(49872): rem equals to 0 when voice 2 ends (1 otherwise)
peek(49876): rem returns the id of the playing sound for voice 0 or 0xFF
peek(49877): rem returns the id of the playing sound for voice 1 or 0xFF
peek(49878): rem returns the id of the playing sound for voice 2 or 0xFF

You create a disk (.D64), add the prg file (e.g.: sfx.prg) and then
load the file from disk (no loader required!) as in the following example code: 

10 if ll=0 then ll=1: load "sfx.prg",8,1
20 poke 54296,15: rem volume on
30 sys 49854: rem enable irq
40 poke 780,0: poke 782,0: sys 49226: rem play sfx on a voice


--------------------------------------------------------------------

In Assembly:

; Setup the IRQ

sei
lda #<my_irq
sta $0314
lda #>my_irq
sta $0315
cli
lda #$0f
sta $d418 ; set volume to 15
lda #0    ; sfx number
ldy #0    ; voice number
jsr $c04a ; play sound!
rts

; irq routine

my_irq:
jsr $c2a9 ; play all voices!
jmp $ea31

In Oscar C if I play i.e. sound num=2 a different sound is played together with sound 0 in a loop. Here is my code:

#include <c64/joystick.h>
#include <c64/vic.h>
#include <c64/sprites.h>
#include <c64/memmap.h>
#include <c64/rasterirq.h>
#include <gfx/bitmap.h>
#include <gfx/mcbitmap.h>
#include <c64/cia.h>
#include <audio/sidfx.h>

#include <c64/sid.h>
#include <math.h>
#include <stdlib.h>
#include <string.h>
#include <stdbool.h>

#pragma section(sfx, 0)
#pragma region(main, 0x0a00, 0xd800, , , {code, data, bss, heap, stack} )
#pragma region(zeropage, 0x80, 0xf8, , , {zeropage})
#pragma region(sfx, 0xc000, 0xd000, , , { sfx } )

#pragma data(sfx)

__export char Sounds[] = {
#embed 1024 2 "../resources/sfx.prg"
};

#pragma data(data)

RIRQCode rmenu;
int remainTimer=0;


#pragma data(code)



void initSfx(byte num)
{
	vic.color_border++;
	
	__asm
	{
        lda #$0f
        sta $d418
        lda num
        ldy #$0
        jsr $c04a	
    };
}

void playSfx()
{
	__asm
	{
        jsr $c2a9
    };
}

__interrupt void snd_interrupt()
{
	joy_poll(1);
	playSfx();
}

void rasterSnd(bool useKernal)
{
	rirq_stop();

	rirq_init(useKernal);
	rirq_build(&rmenu, 1);
	rirq_call(&rmenu, 0, snd_interrupt);
	rirq_set(0, 250, &rmenu);

	rirq_sort();

	rirq_start();	
}

int main()
{
	// Disable CIA interrupts, we do not want interference
	// with our joystick interrupt
	cia_init();
	// Activate trampoline
	mmap_trampoline();

    byte num = 2;

	initSfx(num);

	rasterSnd(true);
	while(true)
	{
		remainTimer++;
		if(remainTimer == 0)
		{
        	initSfx(num);
		}
	}
}

From my view it looks correct but the result is different. Is the memory in 0xc000 overwritten somehow?

[drmortalwombat]

#pragma region(main, 0x0a00, 0xd800, , , {code, data, bss, heap, stack} )
#pragma region(zeropage, 0x80, 0xf8, , , {zeropage})
#pragma region(sfx, 0xc000, 0xd000, , , { sfx } )

the memory from 0xc000 to 0xd000 is double booked in your setup

[drmortalwombat]

And you should not use the IO area for the main region, unless you keep it disables all the time.

[adaumann]

The problem was that I copied 0x400 bytes, but the file is longer. My fault...