Skip to content
This repository was archived by the owner on Dec 7, 2022. It is now read-only.

Commit 7394049

Browse files
committed
Remove comments from github workflows
1 parent 7c4ef3c commit 7394049

File tree

2 files changed

+2
-4
lines changed

2 files changed

+2
-4
lines changed

.github/workflows/go-build.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,5 +42,4 @@ jobs:
4242
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o "mkcert-$(git describe --tags)-windows-amd64.exe" -ldflags "-X main.Version=$(git describe --tags)"
4343
CGO_ENABLED=0 GOOS=windows GOARCH=arm go build -o "mkcert-$(git describe --tags)-windows-arm.exe" -ldflags "-X main.Version=$(git describe --tags)"
4444
CGO_ENABLED=0 GOOS=windows GOARCH=386 go build -o "mkcert-$(git describe --tags)-windows-386.exe" -ldflags "-X main.Version=$(git describe --tags)"
45-
# TODO: When golang v1.16 comes out, make this a simple build using go instead of gotip (lose docker)
46-
docker run --rm -w /workdir -v "$(PWD):/workdir" -e GOPATH="/go" -e "GOCACHE=/workdir/.gotmp" drud/golang-build-container:v1.15.6 bash -c "CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 gotip build -o \"mkcert-$(git describe --tags)-darwin-arm64\" -ldflags \"-X main.Version=$(git describe --tags)\" "
45+
docker run --rm -w /workdir -v "${PWD}:/workdir" -e GOPATH="/go" -e "GOCACHE=/workdir/.gotmp" drud/golang-build-container:v1.15.6 bash -c "CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 gotip build -o \"mkcert-$(git describe --tags)-darwin-arm64\" -ldflags \"-X main.Version=$(git describe --tags)\" "

.github/workflows/go-release.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ jobs:
3939
CGO_ENABLED=0 GOOS=windows GOARCH=amd64 go build -o "mkcert-$(git describe --tags)-windows-amd64.exe" -ldflags "-X main.Version=$(git describe --tags)"
4040
CGO_ENABLED=0 GOOS=windows GOARCH=arm go build -o "mkcert-$(git describe --tags)-windows-arm.exe" -ldflags "-X main.Version=$(git describe --tags)"
4141
CGO_ENABLED=0 GOOS=windows GOARCH=386 go build -o "mkcert-$(git describe --tags)-windows-386.exe" -ldflags "-X main.Version=$(git describe --tags)"
42-
# TODO: When golang v1.16 comes out, make this a simple build using go instead of gotip (lose docker)
43-
docker run --rm -w /workdir -v "$(PWD):/workdir" -e GOPATH="/go" -e "GOCACHE=/workdir/.gotmp" drud/golang-build-container:v1.15.6 bash -c "CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 gotip build -o \"mkcert-$(git describe --tags)-darwin-arm64\" -ldflags \"-X main.Version=$(git describe --tags)\" "
42+
docker run --rm -w /workdir -v "${PWD}:/workdir" -e GOPATH="/go" -e "GOCACHE=/workdir/.gotmp" drud/golang-build-container:v1.15.6 bash -c "CGO_ENABLED=0 GOOS=darwin GOARCH=arm64 gotip build -o \"mkcert-$(git describe --tags)-darwin-arm64\" -ldflags \"-X main.Version=$(git describe --tags)\" "
4443
4544
- name: Publish artifacts
4645
uses: ncipollo/release-action@v1

0 commit comments

Comments
 (0)