Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort migration message #5193

Open
wants to merge 3 commits into
base: 11.x
Choose a base branch
from
Open

Sort migration message #5193

wants to merge 3 commits into from

Conversation

RoSk0
Copy link
Contributor

@RoSk0 RoSk0 commented Jul 27, 2022

Default sort order is based on source IDs hash which is not useful.

Default sort order is based on source IDs hash which is not useful.
@RoSk0 RoSk0 requested a review from claudiu-cristea as a code owner July 27, 2022 10:22
@weitzman
Copy link
Member

weitzman commented Jul 8, 2023

So what column is used for sorting in this PR?

@RoSk0
Copy link
Contributor Author

RoSk0 commented Jul 9, 2023

Hi @weitzman ,

I'm actually not sure now. I don't have that environment to reproduce and confusingly docs are not really helpful.

From memory we had a D7=>D9 node migration, so there was three source ID columns (nid, vid,lang) and with default output sorted by the source ID hash , messages related to a single source node was randomly spread in the output. With that patch, messages related to the same source node was nicely grouped together in the output.

Noticed that the patch missed to sort the output when idlist is provided. Will add that now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants