Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Annotated Commands in favor of native Symfony Console commands #6135

Open
wants to merge 49 commits into
base: 13.x
Choose a base branch
from
Open

Deprecate Annotated Commands in favor of native Symfony Console commands #6135

wants to merge 49 commits into from

Commits on Oct 14, 2024

  1. Deprecate AnnotatedCommands in favor of native Symfony Console commands

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2f63ffc View commit details
    Browse the repository at this point in the history

  2. PHPCS and rename directory to just Listeners (was EventListener)

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ec1f512 View commit details
    Browse the repository at this point in the history

  3. PHPStan

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    47bf610 View commit details
    Browse the repository at this point in the history

  4. Restore handle() methods on a few Formatter Attribute classes

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    a201b1e View commit details
    Browse the repository at this point in the history

  5. A few fixes

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    756d384 View commit details
    Browse the repository at this point in the history

  6. Remove illegal operation

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    000c215 View commit details
    Browse the repository at this point in the history

  7. A bit ugly but test has to pass

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    2eeb287 View commit details
    Browse the repository at this point in the history

  8. Add --filter option automatically for Console commands. Implementatio… 

    …n is in progress
    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    ff65ece View commit details
    Browse the repository at this point in the history

  9. Incorporate into the Trait

    @weitzman
    weitzman committed Oct 14, 2024
    Configuration menu
    Copy the full SHA
    f2f179d View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Support --filter during execute() of formatter supporting commands

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    41a8aa6 View commit details
    Browse the repository at this point in the history

  2. Convert image:flush to a Console command. Add ValidateEntityLoad list… 

    …ener

Shows interact()
    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    141fa70 View commit details
    Browse the repository at this point in the history

  3. Deprecate constants

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2eea0de View commit details
    Browse the repository at this point in the history

  4. Inject a new io service when StyleInterface is the type hint

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    68cad77 View commit details
    Browse the repository at this point in the history

  5. Add visibility and remove use of dt()

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    b3fbd3a View commit details
    Browse the repository at this point in the history

  6. Use io instead of logger for success messages

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    a194c59 View commit details
    Browse the repository at this point in the history

  7. Deal with a PHPStan failure by aliasing SynfonyStyle to DrushStyle in… 

    … \Drush\Runtime\DependencyInjection::alterServicesForDrush
    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    4a9f239 View commit details
    Browse the repository at this point in the history

  8. in ImageFlushCommand, use choice() and remove the deprecation from it 

    Resolves a PHPStan failure.
    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    e78b50a View commit details
    Browse the repository at this point in the history

  9. Convert sql:dump. Optionsets are provided via a Listener

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    2f42025 View commit details
    Browse the repository at this point in the history

  10. PHPCS

    @weitzman
    weitzman committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    ac5ad80 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Experiment with static method to add OptionSets

    @weitzman
    weitzman committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    0239f0f View commit details
    Browse the repository at this point in the history

  2. Demonstrate a static method approach for Validators

    @weitzman
    weitzman committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    8b16ff4 View commit details
    Browse the repository at this point in the history

  3. Experiment with FormatterOptions via code not Attributes

    @weitzman
    weitzman committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    7d6e8ea View commit details
    Browse the repository at this point in the history

  4. Build io when needed - don't get it from the container

    @weitzman
    weitzman committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    9847b61 View commit details
    Browse the repository at this point in the history

  5. Use DI

    @weitzman
    weitzman committed Oct 16, 2024
    Configuration menu
    Copy the full SHA
    b9e11f3 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Less magic - commands that format have own execute() with a bit of bo… 

    …ilerplate
    @weitzman
    weitzman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    6216ad6 View commit details
    Browse the repository at this point in the history

  2. FormatterOptions now has methods we need to deprecate formatting Attr… 

    …ibutes
    @weitzman
    weitzman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    8d7b2e4 View commit details
    Browse the repository at this point in the history

  3. Revert Formatting Attributes and use new fluid syntax for setInput

    @weitzman
    weitzman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    1a795af View commit details
    Browse the repository at this point in the history

  4. Start restore of automatic mention of the formatting help topic 

    Use a web URL instead of the actual topic text.
    @weitzman
    weitzman committed Oct 18, 2024
    Configuration menu
    Copy the full SHA
    680da18 View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2024

  1. Pass formattterOptions during configure()

    @weitzman
    weitzman committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    12e74f8 View commit details
    Browse the repository at this point in the history

  2. Simplify ImageFlushCommands a bit

    @weitzman
    weitzman committed Oct 20, 2024
    Configuration menu
    Copy the full SHA
    74becdc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Start deprecating a few Attribute classes

    @weitzman
    weitzman committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    6c899f4 View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. Minor improvements

    @weitzman
    weitzman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    74b697c View commit details
    Browse the repository at this point in the history

  2. Convert sql:sanitize command. Convert the UserTable sanitizer to a Li… 

    …stener
    @weitzman
    weitzman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    5b55f98 View commit details
    Browse the repository at this point in the history

  3. PHPStan fixes

    @weitzman
    weitzman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    ebd367a View commit details
    Browse the repository at this point in the history

  4. Convert to UserTableFields listener. Needed for green

    @weitzman
    weitzman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    34afdc7 View commit details
    Browse the repository at this point in the history

  5. Introduce writeFormattedOutput() - use in execute()

    @weitzman
    weitzman committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    f923a80 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Just put validators right into the Command 

    Its OK to duplicate a few lines of code
    @weitzman
    weitzman committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    2e75912 View commit details
    Browse the repository at this point in the history

  2. Lets go with calling Optionset methods statically from configure()

    @weitzman
    weitzman committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    a2b44fd View commit details
    Browse the repository at this point in the history

  3. Experiment with CommandTester - it works

    @weitzman
    weitzman committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    b4ed0bf View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Move the install check to setUp()

    @weitzman
    weitzman committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    58c2ddd View commit details
    Browse the repository at this point in the history

Commits on Oct 30, 2024

  1. A bit more experimentation with Applicationtester

    @weitzman
    weitzman committed Oct 30, 2024
    Configuration menu
    Copy the full SHA
    c1056ed View commit details
    Browse the repository at this point in the history

Commits on Oct 31, 2024

  1. Delay getting $application because that can make entitytypeManager stale

    @weitzman
    weitzman committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    8f4f573 View commit details
    Browse the repository at this point in the history

  2. Dont store $application in local variable. it gets stale.

    @weitzman
    weitzman committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    fdfaf0f View commit details
    Browse the repository at this point in the history

  3. drush() method is good enough for now

    @weitzman
    weitzman committed Oct 31, 2024
    Configuration menu
    Copy the full SHA
    3712e5d View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2024

  1. Docs for Console commands

    @weitzman
    weitzman committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    f0ffbd9 View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2024

  1. Merge branch '13.x' into use-command-directly

    @weitzman
    weitzman committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    955511e View commit details
    Browse the repository at this point in the history

  2. Convert image:derive

    @weitzman
    weitzman committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    aa21ad9 View commit details
    Browse the repository at this point in the history

  3. Migrate config:set into a Console command

    @weitzman
    weitzman committed Nov 2, 2024
    Configuration menu
    Copy the full SHA
    8ef8994 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2024

  1. Config:get is now a Console command

    @weitzman
    weitzman committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    b9817b9 View commit details
    Browse the repository at this point in the history