Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request for better "disabled" buttons #3

Open
venkr opened this issue Sep 17, 2022 · 0 comments
Open

Request for better "disabled" buttons #3

venkr opened this issue Sep 17, 2022 · 0 comments

Comments

@venkr
Copy link

venkr commented Sep 17, 2022

I think the following button style looks better for success when it is disabled:

const disabledSuccessStyle = {
        backgroundColor: theme.palette.successLight,
        borderColor: theme.palette.successLight,
        color: "#fff",
      }

I'm not sure I understand exactly how to put this into button/style.ts so would like you to drop this in when you get a chance! Temp workaround is applying these styles outside of sparkl-ui - but I'd like to remove that workaround when possible.

See a before/after comparison:
Recording 2022-09-17 at 11 37 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant