Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup raven.js #22

Open
xcambar opened this issue Aug 7, 2016 · 4 comments
Open

setup raven.js #22

xcambar opened this issue Aug 7, 2016 · 4 comments

Comments

@xcambar
Copy link

xcambar commented Aug 7, 2016

From the README:

automatically setup raven-js? If you want this, let me know.

I think this would be a great addition to the addon as it would allow a simpler setup and overall a better experience of Sentry+Ember.

If it appears relevant to the community, I can guess two options:

  • merge ember-cli-deploy-sentry and ember-cli-sentry
  • use ember-cli-sentry as a dependency for ember-cli-deploy-sentry

I'd be more than happy to discuss the options.

@dschmidt
Copy link
Owner

Second option is basically working already.. ember-cli-sentry and ember-cli-deploy-sentry work along just fine together, it's just that ember-cli-sentry is not a required depdendency

@xcambar
Copy link
Author

xcambar commented Aug 17, 2016

Yes, I understand, yet my point was to highlight that some/all of the apps that use ember-cli-deploy-sentry will most likely want to use ember-cli-sentry, hence it would make sense that ember-cli-deploy-sentry provides and possibly bundles some defaults for ember-cli-sentry.

@RobinDaugherty
Copy link

The two projects work side-by-side, but do not work together without further configuration. This project sets the application revision in a meta tag, but ember-cli-sentry does not use the meta tag, and sends reports with a different revision. I think this worked in the past, but it does not work today.

@duizendnegen
Copy link
Collaborator

@RobinDaugherty check out #39 as a proposal to get rid of the meta tag generally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants