{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":2326047,"defaultBranch":"main","name":"git","ownerLogin":"dscho","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2011-09-05T03:18:21.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/127790?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1719560037.0","currentOid":""},"activityList":{"items":[{"before":"26d612644a5d3682369e6a55b6753053e88d34d8","after":null,"ref":"refs/heads/drop-bogus-_pgmptr-declaration","pushedAt":"2024-06-28T07:33:57.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":"ada96f42ebdcafdafe299b3f0a394d576ee9c9c1","after":null,"ref":"refs/heads/fix-broken-gvfs-protocol-link","pushedAt":"2024-06-24T08:01:39.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":null,"after":"ada96f42ebdcafdafe299b3f0a394d576ee9c9c1","ref":"refs/heads/fix-broken-gvfs-protocol-link","pushedAt":"2024-06-21T10:39:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"fixup! Adjust README.md for microsoft/git\n\nAdjust the currently-broken GVFS Protocol link.\n\nThe current link points to a page that has gone away. While there is\nhttps://web.archive.org/web/20210302002834/https://docs.microsoft.com/en-us/azure/devops/learn/git/gvfs-architecture#gvfs-protocol\nthat _could_ be used to reinstate the link, it is not actually the best\ndocument to which to point the keen reader. We already point interested\nparties to the VFSforGit repository's documentation elsewhere, so let's\nalso do that in the README.\n\nThis fixes https://github.com/microsoft/git/issues/628.\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"fixup! Adjust README.md for microsoft/git"}},{"before":"1580b83e7a79bc9429681c1da6e367703d42d952","after":null,"ref":"refs/heads/increment-progress-in-commit-graph","pushedAt":"2024-06-21T07:01:33.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":null,"after":"26d612644a5d3682369e6a55b6753053e88d34d8","ref":"refs/heads/drop-bogus-_pgmptr-declaration","pushedAt":"2024-06-18T21:20:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"mingw: drop bogus (and unneeded) declaration of `_pgmptr`\n\nIn 08809c09aa13 (mingw: add a helper function to attach GDB to the\ncurrent process, 2020-02-13), I added a declaration that was not needed.\nBack then, that did not matter, but now that the declaration of that\nsymbol was changed in mingw-w64's headers, it causes the following\ncompile error:\n\n CC compat/mingw.o\n compat/mingw.c: In function 'open_in_gdb':\n compat/mingw.c:35:9: error: function declaration isn't a prototype [-Werror=strict-prototypes]\n 35 | extern char *_pgmptr;\n | ^~~~~~\n In file included from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/mm_malloc.h:27,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/xmmintrin.h:34,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/immintrin.h:31,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/lib/gcc/x86_64-w64-mingw32/14.1.0/include/x86intrin.h:32,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/winnt.h:1658,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/minwindef.h:163,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/windef.h:9,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/windows.h:69,\n from C:/git-sdk-64/usr/src/git/build-installers/mingw64/include/winsock2.h:23,\n from compat/../git-compat-util.h:215,\n from compat/mingw.c:1:\n compat/mingw.c:35:22: error: '__p__pgmptr' redeclared without dllimport attribute: previous dllimport ignored [-Werror=attributes]\n 35 | extern char *_pgmptr;\n | ^~~~~~~\n\nLet's just drop the declaration and get rid of this compile error.\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"mingw: drop bogus (and unneeded) declaration of _pgmptr"}},{"before":"fdc78a655170928b19512de09fd9b75846b53dd3","after":null,"ref":"refs/heads/demote-new-fsck-warnings-to-info","pushedAt":"2024-06-12T18:21:06.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":"bc659a26d919451e7b9b2d56e0de714c37f2fcd2","after":null,"ref":"refs/heads/todo-tyops","pushedAt":"2024-06-12T14:47:46.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":"3fa7b624a1b967518c96bdb7e483764d0c1fa9dc","after":"1580b83e7a79bc9429681c1da6e367703d42d952","ref":"refs/heads/increment-progress-in-commit-graph","pushedAt":"2024-06-12T08:31:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"commit-graph: increment progress indicator\n\nThis fixes a bug that was introduced by 368d19b0b7 (commit-graph:\nrefactor compute_topological_levels(), 2023-03-20): Previously, the\nprogress indicator was updated from `i + 1` where `i` is the loop\nvariable of the enclosing `for` loop. After this patch, the update used\n`info->progress_cnt + 1` instead, however, unlike `i`, the\n`progress_cnt` attribute was not incremented. Let's increment it.\n\nTo prevent this from regressing again, extend the existing test case\nt6500.11 'with TTY: gc --no-quiet' to verify that the progress meter\nreaches 100% (without this fix, it would have reached only 25%).\n\nHelped-by: Patrick Steinhardt \nSigned-off-by: Derrick Stolee \nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"commit-graph: increment progress indicator"}},{"before":"8d966385cfcd3ab0541c48ee1858661c7e3dbcb7","after":"3fa7b624a1b967518c96bdb7e483764d0c1fa9dc","ref":"refs/heads/increment-progress-in-commit-graph","pushedAt":"2024-06-12T08:29:32.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"commit-graph: increment progress indicator\n\nThis fixes a bug that was introduced by 368d19b0b7 (commit-graph:\nrefactor compute_topological_levels(), 2023-03-20): Previously, the\nprogress indicator was updated from `i + 1` where `i` is the loop\nvariable of the enclosing `for` loop. After this patch, the update used\n`info->progress_cnt + 1` instead, however, unlike `i`, the\n`progress_cnt` attribute was not incremented. Let's increment it.\n\nTo prevent this from regressing again, extend the existing test case\nt6500.11 'with TTY: gc --no-quiet' to verify that the progress meter\nreaches 100% (without this fix, it would have reached only 25%).\n\nHelped-by: Patrick Steinhardt \nSigned-off-by: Derrick Stolee \nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"commit-graph: increment progress indicator"}},{"before":null,"after":"8d966385cfcd3ab0541c48ee1858661c7e3dbcb7","ref":"refs/heads/increment-progress-in-commit-graph","pushedAt":"2024-06-05T10:42:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"commit-graph: increment progress indicator\n\nThis fixes a bug that was introduced by 368d19b0b7 (commit-graph:\nrefactor compute_topological_levels(), 2023-03-20): Previously, the\nprogress indicator was updated from `i + 1` where `i` is the loop\nvariable of the enclosing `for` loop. After this patch, the update used\n`info->progress_cnt + 1` instead, however, unlike `i`, the\n`progress_cnt` attribute was not incremented. Let's increment it.\n\nSigned-off-by: Derrick Stolee \nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"commit-graph: increment progress indicator"}},{"before":"91d03cb2e4fbf6ad961ace739b8a646868cb154d","after":null,"ref":"refs/heads/rebase-to-v2.45.2","pushedAt":"2024-06-03T09:14:32.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":null,"after":"91d03cb2e4fbf6ad961ace739b8a646868cb154d","ref":"refs/heads/rebase-to-v2.45.2","pushedAt":"2024-06-03T07:36:24.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Fix build with GCC v14.1 (#4962)\n\nThe GCC v14.1 upgrade broke the build of `git-artifacts`. Partially,\r\nthis has been fixed upstream already, but the i686 build requires a\r\nseparate fix.\r\n\r\nThis addresses #4953.","shortMessageHtmlLink":"Fix build with GCC v14.1 (git-for-windows#4962)"}},{"before":"5c576e889d85b34fc717b693ba526cc46836f66a","after":null,"ref":"refs/heads/various-fixes-for-v2.45.1-and-friends","pushedAt":"2024-06-03T07:35:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":null,"after":"fdc78a655170928b19512de09fd9b75846b53dd3","ref":"refs/heads/demote-new-fsck-warnings-to-info","pushedAt":"2024-05-29T12:29:52.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"fsck: demote the newly-introduced symlink issues from WARN -> IGNORE\n\nThe idea of the symlink check to prevent overly-long symlink targets and\ntargets inside the `.git/` directory was to _warn_, but not to prevent\nany operation.\n\nHowever, that's not how Git works, I was confused by the label `WARN`.\nWhat we need instead is the `IGNORE` label, which still warns\n(confusingly so ;-)), but does not prevent any operations from\ncontinuing.\n\nAdjust t1450 accordingly, documenting that `git fsck` unfortunately no\nlonger warns about these issues by default.\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"fsck: demote the newly-introduced symlink issues from WARN -> IGNORE"}},{"before":"45506bb12f0f9fdc49de3b15e6f05bf39001a471","after":null,"ref":"refs/heads/ensure-utf-8-code-page-on-older-windows","pushedAt":"2024-05-26T18:22:23.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":"02fb9be04a63e04628d509e5d5ec7c1e391af7a1","after":"45506bb12f0f9fdc49de3b15e6f05bf39001a471","ref":"refs/heads/ensure-utf-8-code-page-on-older-windows","pushedAt":"2024-05-25T09:50:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"amend! win32: use native ANSI sequence processing, if possible\n\nwin32: use native ANSI sequence processing, if possible\n\nWindows 10 version 1511 (also known as Anniversary Update), according to\nhttps://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences\nintroduced native support for ANSI sequence processing. This allows\nusing colors from the entire 24-bit color range.\n\nAll we need to do is test whether the console's \"virtual processing\nsupport\" can be enabled. If it can, we do not even need to start the\n`console_thread` to handle ANSI sequences.\n\nOr, almost all we need to do: When `console_thread()` does its work, it\nuses the Unicode-aware `write_console()` function to write to the Win32\nConsole, which supports Git for Windows' implicit convention that all\ntext that is written is encoded in UTF-8. The same is not necessarily\ntrue if native ANSI sequence processing is used, as the output is then\nsubject to the current code page. Let's ensure that the code page is set\nto `CP_UTF8` as long as Git writes to it.\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"amend! win32: use native ANSI sequence processing, if possible"}},{"before":null,"after":"02fb9be04a63e04628d509e5d5ec7c1e391af7a1","ref":"refs/heads/ensure-utf-8-code-page-on-older-windows","pushedAt":"2024-05-25T08:55:22.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"amend! win32: use native ANSI sequence processing, if possible\n\nwin32: use native ANSI sequence processing, if possible\n\nWindows 10 version 1511 (also known as Anniversary Update), according to\nhttps://learn.microsoft.com/en-us/windows/console/console-virtual-terminal-sequences\nintroduced native support for ANSI sequence processing. This allows\nusing colors from the entire 24-bit color range.\n\nAll we need to do is test whether the console's \"virtual processing\nsupport\" can be enabled. If it can, we do not even need to start the\n`console_thread` to handle ANSI sequences.\n\nOr, almost all we need to do: When `console_thread()` does its work, it\nuses the Unicode-aware `write_console()` function to write to the Win32\nConsole, which supports Git for Windows' implicit convention that all\ntext that is written is encoded in UTF-8. The same is not necessarily\ntrue if native ANSI sequence processing is used, as the output is then\nsubject to the current code page. Let's ensure that the code page is set\nto `CP_UTF8` as long as Git writes to it.\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"amend! win32: use native ANSI sequence processing, if possible"}},{"before":"e81016e6a3143c33215c45a275b4157e4dd04d5b","after":"ac9ecc8704c910720b646866a438b58fa49b9192","ref":"refs/heads/support-diff-merges-option-in-range-diff","pushedAt":"2024-05-23T10:28:52.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"WIP range-diff: offer to diff also merge commits\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"WIP range-diff: offer to diff also merge commits"}},{"before":null,"after":"e81016e6a3143c33215c45a275b4157e4dd04d5b","ref":"refs/heads/support-diff-merges-option-in-range-diff","pushedAt":"2024-05-23T10:25:38.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"WIP range-diff: offer to diff also merge commits\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"WIP range-diff: offer to diff also merge commits"}},{"before":"aeddcb02756259e4b221f37a60e4ee1ece3889f1","after":"d3c56966d13de6c76f97d9e4045fddff9639b217","ref":"refs/heads/tentative/maint-2.45","pushedAt":"2024-05-22T07:18:07.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.45.2\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.45.2"}},{"before":"616450032a03ee68b1061630d07ef50dc66a81d9","after":"0d21b3451cd941ba4b0710a9aeea7ac1913e56a8","ref":"refs/heads/tentative/maint-2.41","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.41.2\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.41.2"}},{"before":"fff57b200d135fd80c2dbd7c9279b1293c29ee4d","after":"21dc6c4d5218abca3a53eb859492a7fd89263795","ref":"refs/heads/tentative/maint-2.40","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.40.3\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.40.3"}},{"before":"093c42a6c6b2d3fd53cb209381a59fb2bbc90fb5","after":"9926037ce8c9c7129b12926b26c36eaf8ad6e68b","ref":"refs/heads/tentative/maint-2.43","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.43.5\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.43.5"}},{"before":"3c7a7b923b3180221588e79b47c13dc8d2af92f0","after":"aec5a9bf52cd919c81ccde27659aecb4d864f22f","ref":"refs/heads/tentative/maint-2.44","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.44.2\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.44.2"}},{"before":"b1ea89bc2d65d2bedfc551e22b05b043d54552c2","after":"e9bd0c8f8c49d8e7442de950fd727b4a814bb905","ref":"refs/heads/tentative/maint-2.42","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.42.3\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.42.3"}},{"before":"c6da96aa5f048bda2605f4bd6c6aa9e5ffd8a74c","after":"f71d70098149180031634e14bfd8b401b536ff7f","ref":"refs/heads/tentative/maint-2.39","pushedAt":"2024-05-22T07:13:53.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Git 2.39.5\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Git 2.39.5"}},{"before":"af8282d25bc704b09d8bb2f83bfd49327c041557","after":"5c576e889d85b34fc717b693ba526cc46836f66a","ref":"refs/heads/various-fixes-for-v2.45.1-and-friends","pushedAt":"2024-05-22T07:13:16.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"Revert \"Add a helper function to compare file contents\"\n\nNow that during a `git clone`, the hooks' contents are no longer\ncompared to the templates' files', the caller for which the\n`do_files_match()` function was introduced is gone, and therefore this\nfunction can be retired, too.\n\nThis reverts commit 584de0b4c23 (Add a helper function to compare file\ncontents, 2024-03-30).\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"Revert \"Add a helper function to compare file contents\""}},{"before":"68af6e0643afafd756faaafc4095ea765d65870f","after":null,"ref":"refs/heads/fix-upstream-git-build-with-gcc-v14.1-gfw","pushedAt":"2024-05-22T06:38:50.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"}},{"before":null,"after":"68af6e0643afafd756faaafc4095ea765d65870f","ref":"refs/heads/fix-upstream-git-build-with-gcc-v14.1-gfw","pushedAt":"2024-05-21T21:39:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"win32: ensure that `localtime_r()` is declared even in i686 builds\n\nThe `__MINGW64__` constant is defined, surprise, surprise, only when\nbuilding for a 64-bit CPU architecture.\n\nTherefore using it as a guard to define `_POSIX_C_SOURCE` (so that\n`localtime_r()` is declared, among other functions) is not enough, we\nalso need to check `__MINGW32__`.\n\nTechnically, the latter constant is defined even for 64-bit builds. But\nlet's make things a bit easier to understand by testing for both\nconstants.\n\nMaking it so fixes this compile warning (turned error in GCC v14.1):\n\n archive-zip.c: In function 'dos_time':\n archive-zip.c:612:9: error: implicit declaration of function 'localtime_r';\n did you mean 'localtime_s'? [-Wimplicit-function-declaration]\n 612 | localtime_r(&time, &tm);\n | ^~~~~~~~~~~\n | localtime_s\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"win32: ensure that localtime_r() is declared even in i686 builds"}},{"before":null,"after":"5e4f8d94fd67dc224b7341f20ea989bb523ca26e","ref":"refs/heads/fix-upstream-git-build-with-gcc-v14.1","pushedAt":"2024-05-21T21:37:44.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"dscho","name":"Johannes Schindelin","path":"/dscho","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/127790?s=80&v=4"},"commit":{"message":"win32: ensure that `localtime_r()` is declared even in i686 builds\n\nThe `__MINGW64__` constant is defined, surprise, surprise, only when\nbuilding for a 64-bit CPU architecture.\n\nTherefore using it as a guard to define `_POSIX_C_SOURCE` (so that\n`localtime_r()` is declared, among other functions) is not enough, we\nalso need to check `__MINGW32__`.\n\nTechnically, the latter constant is defined even for 64-bit builds. But\nlet's make things a bit easier to understand by testing for both\nconstants.\n\nMaking it so fixes this compile warning (turned error in GCC v14.1):\n\n archive-zip.c: In function 'dos_time':\n archive-zip.c:612:9: error: implicit declaration of function 'localtime_r';\n did you mean 'localtime_s'? [-Wimplicit-function-declaration]\n 612 | localtime_r(&time, &tm);\n | ^~~~~~~~~~~\n | localtime_s\n\nSigned-off-by: Johannes Schindelin ","shortMessageHtmlLink":"win32: ensure that localtime_r() is declared even in i686 builds"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEcZfOzAA","startCursor":null,"endCursor":null}},"title":"Activity ยท dscho/git"}