Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine reference numbers for grid points starting on buys and sells #26

Open
dscotese opened this issue Nov 22, 2022 · 1 comment
Open

Comments

@dscotese
Copy link
Owner

The set command lists all existing reference numbers along with how much was bought and how much was sold and the resulting profit. The problem is that sometimes, for whatever reason, the trade that started as a sell (ref# 2NN[highPrice]) gets replaced as the buy at the lower price (ref# 1NN[lowPrice]).

The fix is to have set recognize that an executed sell at price P matches any executed buy at the next price down, and to therefore list them all together. This only means including both ref#s in each line that set puts out. It would be nice if it also translated the second two digits (which identify the crypto) into the symbol of the crypto. Assuming this is possible, set's output would look like this:

SYMBOL: BuyPrice1 - SellPrice1, bought BBB and sold SSS for PPP
SYMBOL: BuyPrice2 - SellPrice2, bought BBB and sold SSS for PPP
SYMBOL: BuyPrice3 - SellPrice3, bought BBB and sold SSS for PPP
@dscotese
Copy link
Owner Author

With the refactor #30 , there is no longer a limited set of pairs, and user reference numbers now use three digits to identify the pair, not two. The feature request is still valid but not yet important to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant