Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Archive page titles #206

Open
metbril opened this issue Aug 16, 2018 · 1 comment
Open

Archive page titles #206

metbril opened this issue Aug 16, 2018 · 1 comment

Comments

@metbril
Copy link

metbril commented Aug 16, 2018

Archive page titles for post kinds (https://www.example.com/kind/like) use strings that are maintained somewhere in the plugin code and can be translated. However, these are actually taxonomies with their own slugs, titles and descriptions.

Taxonomies can be used to create menus. I do this and try to rely on the customized titles (translated into Dutch, actually). And the paragraph with the description.

I would like the plugin to use the taxonomy properties wherever possible, so that maintenance can be done in one place.

Update: the get_kind_info now sets a string, but should get the values from the taxonomy record, I guess.

Instead of getting the value from the array:

'name' => __( 'Likes', 'indieweb-post-kinds' ), // General name for the kind plural

instead do something like

$term = get_term('like', 'kind');
...
name => $term->name,
@dshanske
Copy link
Owner

This might be fixed in the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants