Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check compatibility with .NET 8 #196

Closed
SOsterbrink opened this issue Oct 11, 2023 · 4 comments · Fixed by #211
Closed

Check compatibility with .NET 8 #196

SOsterbrink opened this issue Oct 11, 2023 · 4 comments · Fixed by #211

Comments

@SOsterbrink
Copy link
Member

We need to check how .NET 8 compatibility can be achieved and how .NET 8 will affect our tool.

https://learn.microsoft.com/en-us/dotnet/core/whats-new/dotnet-8

@gureedo
Copy link

gureedo commented Nov 15, 2023

I faced strange error.
dscom fails to export tlb if assembly references System.Security.Cryptography.
Interop+BCrypt+BCRYPT_DSA_KEY_BLOB_V2+<Count>e__FixedBuffer, System.Security.Cryptography, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a
I think it's related to .NET 8.

@SOsterbrink
Copy link
Member Author

Thank you for the example. I'll include it in some of my tests.

The current dscom version is not yet built with .NET 8. It's likely that most interactions with System libraries from .NET 8 will create errors.

SOsterbrink added a commit that referenced this issue Nov 16, 2023
@SOsterbrink
Copy link
Member Author

I faced strange error. dscom fails to export tlb if assembly references System.Security.Cryptography. Interop+BCrypt+BCRYPT_DSA_KEY_BLOB_V2+<Count>e__FixedBuffer, System.Security.Cryptography, Version=8.0.0.0, Culture=neutral, PublicKeyToken=b03f5f7f11d50a3a I think it's related to .NET 8.

The dscom problem is rooted in the fact that for some reason System.Security.Cryptography does not have a namespace.
And we expect that every library has a namespace.

@SOsterbrink
Copy link
Member Author

SOsterbrink commented Nov 16, 2023

The behavior in connection with the System.Security.Cryptography library is moved into a separate issue #210 , because it's not a general problem with .NET 8

@SOsterbrink SOsterbrink linked a pull request Nov 17, 2023 that will close this issue
marklechtermann added a commit that referenced this issue Nov 20, 2023
* feat: Added .NET 8 Build Targets
#196

* chore: Removed some warning introduced by .NET 8
#196

* chore: moved suppressions to the editorconfig

* chore: removed warning that is handled by the editorconfig

* chore: Added missing documentation and remove warnings

* fix: global.json uses the same config as BuildProps

* fix: Turned back the global.json to use .NET 8

* chore: Removed compile warnings

---------

Co-authored-by: Mark Lechtermann <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants