Honor [ComVisible(false)] method atrtibutes in advance

[gureedo]

I have simple example:

public interface IMyClass {
    [ComVisible(false)] 
    public System.Security.Cryptography.X509Certificates.X509RevocationMode RevocationMode { get; set; }
}
public class MyClass: IMyClass {
    public System.Security.Cryptography.X509Certificates.X509RevocationMode RevocationMode { get; set; }
}

If I run tlbexport with --createmissingdependenttlbs false there will be warnings in output.

dscom : warning TX00000000 : The referenced library System.Security.Cryptography does not have a type library and auto generation of dependent type libs is disabled

[SOsterbrink]

So to understand your Issue, your expectation is that a [ComVisible(false)] from the interface is propagated to the implementing property? And that the implementing property is automatically also [ComVisible(false)]

Because if that's the case I'll have to check whether that's the expected behavior. We tried to have the same behavior as the old tlbexp.

[SOsterbrink]

For the generation of the tlb we ignore the property with [ComVisible(false)]. The problem is now that we have to also check methods and properties that are invisible to COM once to calculate some things like the offset of the VTable.

So we produce an unnecessary warning during the generation process.

[gureedo]

So we produce an unnecessary warning during the generation process.

Yes. Right.

[marklechtermann]

The problem here is that the TypeLibExporterNotifySink is informed that a TLB was not found.
This is because a MethodWriter is created, although this is only needed to calculate the VTableOffset.

One solution would be not to create the MethodWriter in the case of a property/method that is ComVisible=false.

in InterfaceWriter.cs e.g:

private void CreateMethodWriters()
    {
         ...
        foreach (var method in methods)
        {
            var methodAttribute = method.GetCustomAttribute<ComVisibleAttribute>();
            if (methodAttribute == null || methodAttribute.Value)
            {
                // Add a null entry
                // This is needed to keep the correct order of the methods to calculate the VTableOffset
                MethodWriter.Add(null);
            }
   ...

@SOsterbrink This should solve the problem ... maybe