From 38065b63f20850aa7620f2bdeaef1611e89cfdea Mon Sep 17 00:00:00 2001 From: Shirox Date: Wed, 5 Jun 2019 16:40:21 +0900 Subject: [PATCH 1/2] Fix CloudWatch alarm template about dimensions --- lib/terraforming/template/tf/cloud_watch_alarm.erb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/terraforming/template/tf/cloud_watch_alarm.erb b/lib/terraforming/template/tf/cloud_watch_alarm.erb index 4a859934..edb95203 100644 --- a/lib/terraforming/template/tf/cloud_watch_alarm.erb +++ b/lib/terraforming/template/tf/cloud_watch_alarm.erb @@ -19,7 +19,7 @@ resource "aws_cloudwatch_metric_alarm" "<%= normalize_module_name(alarm.alarm_na actions_enabled = <%= alarm.actions_enabled %> <%- end -%> <%- unless alarm.dimensions.empty? -%> - dimensions { + dimensions = { <% alarm.dimensions.each do |dimension| -%> <%= dimension.name %> = "<%= dimension.value %>" <% end -%> From a49f5858b5fac24e7097ac267258418d6e5fc91e Mon Sep 17 00:00:00 2001 From: Shirox Date: Wed, 5 Jun 2019 18:44:49 +0900 Subject: [PATCH 2/2] Fix CloudWatch alarm template about dimensions --- spec/lib/terraforming/resource/cloud_watch_alarm_spec.rb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/spec/lib/terraforming/resource/cloud_watch_alarm_spec.rb b/spec/lib/terraforming/resource/cloud_watch_alarm_spec.rb index b2eb6dd1..d9a75dfd 100644 --- a/spec/lib/terraforming/resource/cloud_watch_alarm_spec.rb +++ b/spec/lib/terraforming/resource/cloud_watch_alarm_spec.rb @@ -60,7 +60,7 @@ module Resource threshold = "10000.0" alarm_description = "" alarm_actions = ["arn:aws:sns:region:account:lambda-alerts"] - dimensions { + dimensions = { FunctionName = "beep-beep" } }