Skip to content

Bugfix: Update jar versions in METviewer/bin scripts #603

@bikegeek

Description

@bikegeek

Replace italics below with details for this issue.

Describe the Problem

The following METviewer scripts need the snakeyaml and guava jar versions updated, and the juli-6.0.53.jar must be removed from the following scripts in METviewer/bin:

  • mv_scorecard.sh
  • mv_batch.sh
  • mv_compare.sh
  • mv_test.sh
  • mv_scrub.sh
  • mv_prune.sh

The guava and snakeyaml jar file versions were updated to address critical CVE's and the juli-x.y.z.jar is no longer needed (due to an updated Tomcat version). This discrepancy impacts users that are using any of the above scripts from the command line where METviewer is installed or from within a bash shell in a METviewer Docker container.

Recommended fix:

  • Place the jar file information in one location and reference it from the above scripts to avoid duplication and future omissions.
  • In this single location, update the affected jar file versions.
  • Add content to the METviewer Contributor's Guide to document what requires updating when jar file versions change.
  • Create same changes for the METviewer 6.0.1 release and re-release
  • Create same changes for the METviewer 6.1 release and re-release

Expected Behavior

Provide a clear and concise description of what you expected to happen here.

Environment

Describe your runtime environment:
1. Machine: (e.g. HPC name, Linux Workstation, Mac Laptop)
2. OS: (e.g. RedHat Linux, MacOS)
3. Software version number(s)

To Reproduce

Describe the steps to reproduce the behavior:
1. Go to '...'
2. Click on '....'
3. Scroll down to '....'
4. See error
Post relevant sample data following these instructions:
https://dtcenter.org/community-code/model-evaluation-tools-met/met-help-desk#ftp

Relevant Deadlines

List relevant project deadlines here or state NONE.

Funding Source

Define the source of funding and account keys here or state NONE.

Define the Metadata

Assignee

  • Select engineer(s) or no engineer required
  • Select scientist(s) or no scientist required

Labels

  • Review default alert labels
  • Select component(s)
  • Select priority
  • Select requestor(s)

Milestone and Projects

  • Select Milestone as the next bugfix version
  • Select Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Select METviewer-X.Y.Z Development project for development toward the next official release

Define Related Issue(s)

Consider the impact to the other METplus components.

Bugfix Checklist

See the METplus Workflow for details.

  • Complete the issue definition above, including the Time Estimate and Funding Source.
  • Fork this repository or create a branch of main_<Version>.
    Branch name: bugfix_<Issue Number>_main_<Version>_<Description>
  • Fix the bug and test your changes.
  • Add/update log messages for easier debugging.
  • Add/update unit tests.
  • Add/update documentation.
  • Push local changes to GitHub.
  • Submit a pull request to merge into main_<Version>.
    Pull request: bugfix <Issue Number> main_<Version> <Description>
  • Define the pull request metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next bugfix version
    Select: Coordinated METplus-X.Y Support project for support of the current coordinated release
  • Iterate until the reviewer(s) accept and merge your changes.
  • Delete your fork or branch.
  • Complete the steps above to fix the bug on the develop branch.
    Branch name: bugfix_<Issue Number>_develop_<Description>
    Pull request: bugfix <Issue Number> develop <Description>
    Select: Reviewer(s) and Development issue
    Select: Milestone as the next official version
    Select: METviewer-X.Y.Z Development project for development toward the next official release
  • Close this issue.

Metadata

Metadata

Assignees

Type

Projects

Status

🩺 Needs Triage

Relationships

None yet

Development

No branches or pull requests

Issue actions