From d445704871c256be3540184ac338af3c9fedc457 Mon Sep 17 00:00:00 2001 From: dteviot Date: Wed, 3 Mar 2021 20:53:53 +1300 Subject: [PATCH] Update unit test instructions. See: https://github.com/dteviot/WebToEpub/issues/483 --- CONTRIBUTING.md | 2 +- readme.md | 6 +++++- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 28ef6668..f4bb7d12 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -1,5 +1,5 @@ ## Pull Request Check List -* Do all existing unit tests pass? +* Do all existing unit tests pass? (FYI, I find it easier to get the unit tests to run under Firefox, instead of Chrome.) * Have all warnings and errors reported by eslint been fixed? * If you've added new behavior, * Can a user turn it off? diff --git a/readme.md b/readme.md index df65043a..9df75247 100644 --- a/readme.md +++ b/readme.md @@ -123,7 +123,11 @@ WebToEpub uses the following libraries: ## Other notes ### To run unit tests under Chrome * Close all running copies of Chrome -* Start Chrome with command line argument --allow-file-access-from-files +* Start Chrome with command line argument --allow-file-access-from-files. That is: + * Open a command propmt + * Browse to the directory holding Chrome + * Type in command "chrome.exe --allow-file-access-from-files" without the quotes. Press "Enter". + * If you don't do this, some tests will fail with error messages containing the text **_Failed to execute 'send' on 'XMLHttpRequest': Failed to load_**. * Load unitTest/Tests.html * If you get **_Failed to read the 'localStorage' property from 'Window': Access is denied for this document_** errors * Type **_chrome://settings/content_** into Chrome's search bar