Merge pull request #423 from dtolnay/trackcaller

Track caller for Ident validation panics

Author: dtolnay

src/fallback.rs

@@ -755,6 +755,7 @@ pub(crate) struct Ident {
 }
 
 impl Ident {
+    #[track_caller]
     pub fn new_checked(string: &str, span: Span) -> Self {
         validate_ident(string);
         Ident::new_unchecked(string, span)
@@ -768,6 +769,7 @@ impl Ident {
         }
     }
 
+    #[track_caller]
     pub fn new_raw_checked(string: &str, span: Span) -> Self {
         validate_ident_raw(string);
         Ident::new_raw_unchecked(string, span)
@@ -798,6 +800,7 @@ pub(crate) fn is_ident_continue(c: char) -> bool {
     unicode_ident::is_xid_continue(c)
 }
 
+#[track_caller]
 fn validate_ident(string: &str) {
     if string.is_empty() {
         panic!("Ident is not allowed to be empty; use Option<Ident>");
@@ -826,6 +829,7 @@ fn validate_ident(string: &str) {
     }
 }
 
+#[track_caller]
 fn validate_ident_raw(string: &str) {
     validate_ident(string);
 

src/lib.rs

@@ -950,6 +950,7 @@ impl Ident {
     ///   style="padding-right:0;">syn::parse_str</code></a><code
     ///   style="padding-left:0;">::&lt;Ident&gt;</code>
     /// rather than `Ident::new`.
+    #[track_caller]
     pub fn new(string: &str, span: Span) -> Self {
         Ident::_new(imp::Ident::new_checked(string, span.inner))
     }
@@ -959,6 +960,7 @@ impl Ident {
     /// (including keywords, e.g. `fn`). Keywords which are usable in path
     /// segments (e.g. `self`, `super`) are not supported, and will cause a
     /// panic.
+    #[track_caller]
     pub fn new_raw(string: &str, span: Span) -> Self {
         Ident::_new(imp::Ident::new_raw_checked(string, span.inner))
     }

src/wrapper.rs

@@ -639,6 +639,7 @@ pub(crate) enum Ident {
 }
 
 impl Ident {
+    #[track_caller]
     pub fn new_checked(string: &str, span: Span) -> Self {
         match span {
             Span::Compiler(s) => Ident::Compiler(proc_macro::Ident::new(string, s)),
@@ -650,6 +651,7 @@ impl Ident {
         Ident::Fallback(fallback::Ident::new_unchecked(string, span))
     }
 
+    #[track_caller]
     pub fn new_raw_checked(string: &str, span: Span) -> Self {
         match span {
             Span::Compiler(s) => Ident::Compiler(proc_macro::Ident::new_raw(string, s)),