Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VenetianBlind.js this.stateless breaks blindMode #522

Open
mman opened this issue Apr 29, 2024 · 0 comments
Open

VenetianBlind.js this.stateless breaks blindMode #522

mman opened this issue Apr 29, 2024 · 0 comments

Comments

@mman
Copy link
Contributor

mman commented Apr 29, 2024

The commit b2fda5c

introduced the change around VenetianBlind.js line 45

if (!this.stateless) {
where if the device is reported as !this.stateless it will only allow full open or full close. I read that if the device is !this.stateless it is stateful and therefore able to report back its states?

I am not sure where this.stateless actually comes from, but it appears that my Somfy IO blinds are being reported as !this.stateless (therefore stateful) and therefore never reach the branch handling the blindMode: true setting on line 58.

} else if (this.blindMode) {

I have fixed this by reverting the commit above but I suppose there should be a more systematic fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant