Skip to content

Commit fdb85c9

Browse files
committed
better nested namespace support
1 parent 3acb413 commit fdb85c9

File tree

2 files changed

+6
-3
lines changed

2 files changed

+6
-3
lines changed

src/catalog_api.cpp

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@
1717
using namespace duckdb_yyjson;
1818
namespace duckdb {
1919

20-
vector<string> IRCAPI::ParseSchemaName(string &namespace_name) {
20+
vector<string> IRCAPI::ParseSchemaName(const string &namespace_name) {
2121
idx_t start = 0;
2222
idx_t end = namespace_name.find(".", start);
2323
vector<string> ret;
@@ -65,10 +65,13 @@ string IRCAPI::GetEncodedSchemaName(const vector<string> &items) {
6565
}
6666

6767
bool IRCAPI::VerifySchemaExistence(ClientContext &context, IRCatalog &catalog, const string &schema) {
68+
auto namespace_items = ParseSchemaName(schema);
69+
auto schema_name = GetEncodedSchemaName(namespace_items);
70+
6871
auto url_builder = catalog.GetBaseUrl();
6972
url_builder.AddPathComponent(catalog.prefix);
7073
url_builder.AddPathComponent("namespaces");
71-
url_builder.AddPathComponent(schema);
74+
url_builder.AddPathComponent(schema_name);
7275

7376
auto url = url_builder.GetURL();
7477
try {

src/include/catalog_api.hpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ class IRCAPI {
3030
static bool VerifySchemaExistence(ClientContext &context, IRCatalog &catalog, const string &schema);
3131
static bool VerifyTableExistence(ClientContext &context, IRCatalog &catalog, const IRCSchemaEntry &schema,
3232
const string &table);
33-
static vector<string> ParseSchemaName(string &namespace_name);
33+
static vector<string> ParseSchemaName(const string &namespace_name);
3434
static string GetSchemaName(const vector<string> &items);
3535
static string GetEncodedSchemaName(const vector<string> &items);
3636
static void GetTables(ClientContext &context, IRCatalog &catalog, const IRCSchemaEntry &schema,

0 commit comments

Comments
 (0)