Add bucket-transform-aware partition pruning#1176
Merged
Merged
Conversation
Collaborator
Author
|
We could alternatively make |
Member
|
Thanks, LGTM, can you just fix the failing CI? |
Collaborator
Author
|
@pdet done! Basically all partitioning tests are skipped in Quack in the first place because of a known limitation. So I just added the new test to the skip list only for Quack! |
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Equality and IN-list predicates on
bucket()-partitioned columns now prune files viaducklake_file_partition_valueat scan-planning time. Bucket hashes are computed in C++ so the catalog SQL stays backend-agnostic. Range predicates fall through to the existing zone-map path.Basically makes lookup queries useful with buckets. Zone-maps are not really effective for hashed transforms.