Update table stats for compaction rewrites#1220
Open
jdctinuiti wants to merge 6 commits into
Open
Conversation
Member
|
Cc @dentiny I will take a look later |
jdctinuiti
force-pushed
the
compaction-table-stats
branch
4 times, most recently
from
5885442 to
61dd211
Compare
jdctinuiti
force-pushed
the
compaction-table-stats
branch
from
61dd211 to
e6d33e7
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #1172 (drop-data-files-procedure).
This updates compaction commits to adjust ducklake_table_stats.record_count and file_size_bytes for both ducklake_rewrite_data_files and ducklake_merge_adjacent_files. The change computes removed/added data-file deltas and applies them through the existing global table-stats update path introduced in #1172, preserving next_row_id and existing column stats.
Adds a focused SQL regression covering rewrite-delete with output, merge-adjacent, inlined-file-delete rewrite, and zero-output rewrite after flushing fully-deleted inlined data.