Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Duo Admin User Struct with available fields #52

Merged
merged 4 commits into from
Apr 8, 2024

Conversation

Yohan460
Copy link
Contributor

@Yohan460 Yohan460 commented Apr 2, 2024

Description

Updating the Duo Admin API User structure to contain the updated structure fields. Currently Webauthn and U2F tokens are completely unretrievable via the API

How Has This Been Tested?

No tests existed for the previous functionality

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Copy link
Contributor

@jeffreyparker jeffreyparker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I added a few small comments, but overall looks great.

admin/admin.go Outdated Show resolved Hide resolved
admin/admin.go Outdated Show resolved Hide resolved
admin/admin.go Outdated Show resolved Hide resolved
@jeffreyparker
Copy link
Contributor

Thanks for the quick fixes! This looks good-to-go now. We avoid releasing on Fridays, and because of golang's "master is immediately released" nature, we'll approve/merge this in on Monday.

@jeffreyparker jeffreyparker merged commit cb17708 into duosecurity:master Apr 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants