-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Problem with session.cookie_samesite = "Strict" #2
Comments
@joszz I've run into a similar issue with the C# client. The examples are purposely simplistic around the mechanism to store the state and username, because of this very issue - the best way to persist that information will definitely vary depending on the web application's architecture and security controls. Do you have a suggestion for a note that we could add after
to make it clear to developers? |
hmm, not so easy to come up with something to the point :) |
How about
|
I could be missing something here, but I do not see CORS impacting the functionality. |
We've had reports on some of the other languages' repos about CORS issues, from people that are using it from XHR requests. Though actually, that affects the redirect behavior and not the session storage, so it probably doesn't belong here anyway. So maybe just
|
hmm curious now about the async requests, might look into that :) |
Check out duosecurity/duo_universal_python#1 re the CORS issue. We've also had folks contact our support team about it too. I'll try to get the comment update in soon. |
Added comment from above to example. Commit e108fc9 |
The examples do not work when PHP is configured with;
session.cookie_samesite = "Strict"
Which makes sense since the callback URL is originating from the DUO servers, and strict is preventing cookies from being sent when this is the case.
Maybe a note about this is in place?
A workaround could be storing state in a DB.
The text was updated successfully, but these errors were encountered: