-
Notifications
You must be signed in to change notification settings - Fork 3
Update for python 2/3 #24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Updates
|
@pochedls when you get around to getting a first cut, it would be great to get this dropped in a branch - let me know if you need write access to the repo.. I just started migrating myself to py3, and hit problems with this library (as you said!) |
@durack1 - I think I got this library to the point where I could import it without error and use trimModelList, but I think I broke Python 2. I could push what I have in a branch if you'd like to look at it or in a couple days I'll have more confidence in my modifications. |
@pochedls perfect, if you want to push this to a branch then I can start trying this out with py2, then you can work to ensure py3 works, and I can make sure it's still working in py2.. |
@durack1 - I just pushed branch py23. I think one issue (others will surely popup) is that urllib and urllib2 are different. I'd appreciate if you took a look at this logic. Or I could come up with a couple cases and check-in with you if we have the right behavior when you're back in town. |
@pochedls it imports, nice.. Not sure I'd be able to test this until I get back, but looks like you've done most of the work, thanks! |
Not sure... I also don't think durolib is not setup to work with the new xml files. I think I wrote a function that deals with the new files in Python 3. Shoot @durack1 and I an e-mail and we can discuss implementation. |
@durack1 I use |
@pochedls over to you
The text was updated successfully, but these errors were encountered: