Explicitly cover todos for unknown bitstring types

Author: dusty-phillips

src/compiler/internal/generator/expressions.gleam

@@ -201,6 +201,7 @@ fn generate_bitstring_segment_option(
       |> string_builder.prepend("\"Unit\", ")
 
     python.FloatOption -> string_builder.from_string("\"Float\", None")
+    python.IntOption -> string_builder.from_string("\"Int\", None")
     python.BigOption -> string_builder.from_string("\"Big\", None")
     python.LittleOption -> string_builder.from_string("\"Little\", None")
     python.NativeOption -> string_builder.from_string("\"Native\", None")

src/compiler/internal/transformer/statements.gleam

@@ -549,6 +549,7 @@ fn fold_bitsting_segment_option(
   internal.ReversedList(python.BitStringSegmentOption),
 ) {
   case option {
+    glance.IntOption -> internal.map_state_prepend(state, python.IntOption)
     glance.FloatOption -> internal.map_state_prepend(state, python.FloatOption)
     glance.LittleOption ->
       internal.map_state_prepend(state, python.LittleOption)
@@ -577,13 +578,12 @@ fn fold_bitsting_segment_option(
       )
     }
 
-    glance.SignedOption | glance.UnsignedOption -> {
-      panic as "Signed and unsigned are not valid when constructing bitstrings"
-    }
+    glance.Utf8CodepointOption
+    | glance.Utf16CodepointOption
+    | glance.Utf32CodepointOption ->
+      todo as "codepoints not supported in bitstrings yet"
 
-    _ -> {
-      pprint.debug(option)
-      todo as "Some bitstring segment options not supported yet"
-    }
+    glance.SignedOption | glance.UnsignedOption | glance.BinaryOption ->
+      panic as "Signed, unsigned, and binary are not valid when constructing bitstrings"
   }
 }

src/compiler/python.gleam

@@ -59,6 +59,7 @@ pub type BitStringSegmentOption {
   SizeValueOption(Expression)
   UnitOption(Int)
   FloatOption
+  IntOption
   LittleOption
   BigOption
   BitStringOption

test/bitstring_test.gleam

@@ -183,6 +183,21 @@ def main():
   )
 }
 
+pub fn explicit_int_test() {
+  "pub fn main() {
+      <<42:int>>
+  }
+  "
+  |> compiler.compile
+  |> should.be_ok
+  |> should.equal(
+    "from gleam_builtins import *
+
+def main():
+    return gleam_bitstring_segments_to_bytes((42, [(\"Int\", None)]))",
+  )
+}
+
 pub fn bitstring_test() {
   // TODO: Pretty sure this should be :bits, not :bit_string,
   // but glance has a bug:
@@ -200,3 +215,63 @@ def main():
     return gleam_bitstring_segments_to_bytes((gleam_bitstring_segments_to_bytes((3, [])), [(\"BitString\", None)]))",
   )
 }
+
+pub fn u8_test() {
+  "pub fn main() {
+      <<\"hello\":utf8>>
+  }
+  "
+  |> compiler.compile
+  |> should.be_ok
+  |> should.equal(
+    "from gleam_builtins import *
+
+def main():
+    return gleam_bitstring_segments_to_bytes((\"hello\", [(\"Utf8\", None)]))",
+  )
+}
+
+pub fn u16_test() {
+  "pub fn main() {
+      <<\"hello\":utf16>>
+  }
+  "
+  |> compiler.compile
+  |> should.be_ok
+  |> should.equal(
+    "from gleam_builtins import *
+
+def main():
+    return gleam_bitstring_segments_to_bytes((\"hello\", [(\"Utf16\", None)]))",
+  )
+}
+
+pub fn u32_test() {
+  "pub fn main() {
+      <<\"hello\":utf32>>
+  }
+  "
+  |> compiler.compile
+  |> should.be_ok
+  |> should.equal(
+    "from gleam_builtins import *
+
+def main():
+    return gleam_bitstring_segments_to_bytes((\"hello\", [(\"Utf32\", None)]))",
+  )
+}
+
+pub fn u32_little_test() {
+  "pub fn main() {
+      <<\"hello\":utf32-little>>
+  }
+  "
+  |> compiler.compile
+  |> should.be_ok
+  |> should.equal(
+    "from gleam_builtins import *
+
+def main():
+    return gleam_bitstring_segments_to_bytes((\"hello\", [(\"Utf32\", None), (\"Little\", None)]))",
+  )
+}