Part of the video is cropped

[nathanoy]

I'm encountering an issue with the Upscale feature where parts of the video get cut off. This happens because some videos have black bars baked into them. It would be great if the extension could detect these black bars and adjust the scaling automatically so that no part of the video gets cropped.

[dvlden]

Thank you for your input @nathanoy .
I already had the same idea recently, but it's just impossible to detect baked-in black bars.

I tried detecting black pixels from top edge of the video size using canvas painting, and do the scanning for ~3 seconds of video start, but it wasn't performant and it had issues on many videos. So I dropped it right away.

In an upcoming future update, there will be a change with internal functionality and modes will now rely on scaling options. So if you choose to scale, you can then manually tweak a little bit more if there are built-in black bars. Unlike the current approach where you need to set Normal to be able to use scaling options properly.

Hope that makes sense to you.

[nathanoy]

Yeah, sounds awesome. I can imagine that detecting the black bar poses some difficulties.

On another Note:
In my opinion the scale x and scale y settings should be linked by default. I assume that in most cases one wants to keep the aspect ratio.

Perhaps a key bind for the scaling with the scroll wheel would be awesome. Like Ctrl + Alt + scroll would adjust the scaling factor. This way one can quickly find the perfect scaling factor.