Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature suggestion: settings to affect API callback rate #308

Open
shinmai opened this issue Feb 9, 2024 · 1 comment
Open

Feature suggestion: settings to affect API callback rate #308

shinmai opened this issue Feb 9, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@shinmai
Copy link

shinmai commented Feb 9, 2024

I see there are several issues discussing the fact that lofi hammers the Spotify API ~125 times per minute (getCurrentlyPlaying alone gets called once per second +change), with various suggested fixes/changes, but none of them seem to have gotten any love in years.

Would it be possible to just add a setting to allow users to throttle the rate at which, say, getCurrentlyPlaying is called or to disable the Like feature entirely?
If the former was set to two seconds instead of one, the number of requests would be reduced by 40%, the latter would reduce the number by 20%.

I genuinely don't care if lofi is out of sync with Spotify playback for a few seconds when songs change or to see if I've liked the track or not, but it IS very annoying to constantly see the "API calls throttled, wait Xs..." in the track info and have the playback controls be extremely unreliable.

I realise this would not be a huge change to make myself for a custom build, but if I could avoid having to install Python 2 and MS Build Tools, I would prefer that 😅

@stamoun stamoun added the enhancement New feature or request label Feb 9, 2024
@stamoun
Copy link
Collaborator

stamoun commented Feb 9, 2024

Good idea, so if I summarize you'd like two things:

  • configure the delay to retrieve song info
  • remove the throttle warning (which honestly I did hastily) from the track info (maybe just as an icon like it was before, although the way the code sits it's not possible to have a tooltip right now)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants