Skip to content
This repository has been archived by the owner on May 28, 2022. It is now read-only.

soup/trace/quarr/etc repeat one too many times #174

Open
jcooper-korg opened this issue Jun 26, 2019 · 3 comments
Open

soup/trace/quarr/etc repeat one too many times #174

jcooper-korg opened this issue Jun 26, 2019 · 3 comments

Comments

@jcooper-korg
Copy link
Contributor

e.g. "ampersand soup" should produce "&&" but produces "&&&".
or "say hello trace" should produce "hellohellohello" but does "hellohellohellohello"

@jcooper-korg
Copy link
Contributor Author

We're porting these from voicecode, and it is specified in https://voicecode.io/doc/repetition:

"Hello repple two" should be equivalent to "hello soup" both with should produce "hellohello").

This also clarifies that repple 1 and wink will give the same results as repple 2 and soup :

Note, 'hello repple one' will also output hellohello, as in this case it means 'repeat previous once more', whereas every parameter more than 1 means 'repeat previous N times in total'

jcooper-korg added a commit to jcooper-korg/talon_community that referenced this issue Jun 27, 2019
@dwiel
Copy link
Owner

dwiel commented Jun 27, 2019

The other use case is two separate phrases: "bang" pause "trace". In that case what did voicecode do? And what do we want it to do?

@jcooper-korg
Copy link
Contributor Author

The result of "bang" pause "trace" (or "bang" pause "repple 3") should be "!!!".

every parameter more than 1 means 'repeat previous N times in total'

This is consistent with how it's worked since the early days of voicecode.

dwiel pushed a commit that referenced this issue Jul 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants