Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StyleEditor Errors using Internet Explorer #92

Open
kyscott opened this issue Jan 6, 2020 · 11 comments
Open

StyleEditor Errors using Internet Explorer #92

kyscott opened this issue Jan 6, 2020 · 11 comments

Comments

@kyscott
Copy link

kyscott commented Jan 6, 2020

I noticed an issue with using the StyleEditor in Internet Explorer. When trying to open a page with a Leaflet Map with the StyleEditor integrated, the page doesn't load and the console throws an error. It says that it's looking for a ':' in the Form.js file on the line with the function called "showFormElementForStyleOption". I believe this may be an error with ES6 as everything works fine in Firefox, Chrome and Edge.

Is this is a known issue and is there a possible resolution to make things work in Internet Explorer?

@fupduck
Copy link
Collaborator

fupduck commented Jan 7, 2020

Currently I use the babel default and everything is transpiled to ES6.
Changing this should not be too difficult.
I'll have a look. What IE do you want to support?

@kyscott
Copy link
Author

kyscott commented Jan 7, 2020

Got ya, I appreciate it. It would be IE 11 that I'd want to support.

@fupduck
Copy link
Collaborator

fupduck commented Jan 14, 2020

@kyscott Did this problem resolve? It should work on IE11, as it is only ES5 - but I have no option to test this.

@pipedreamer007
Copy link

@fupduck I noticed in the project's package.json that the "main" property points to source code rather than the distribution directory's minified javascript. Could you modify it to point to the minified javascript file?

By doing this, I believe @kyscott and everyone else will get access to your transpiled IE 11-compatible code...as the source code itself isn't IE 11-compatible. Many thanks for your help & work!

@fupduck
Copy link
Collaborator

fupduck commented Feb 7, 2020

@pipedreamer007 Thanks for the hint.
I thought it would be good practice to point to the non minified version as this helps other projects which use i.e. webpack.
I just read https://stackoverflow.com/questions/48673408/should-javascript-npm-packages-be-minified and will try to create a new npmjs package.
I suggest either 'leaflet-styleeditor-minified' of 'leaflet-styleeditor-es5'.

@EvoDevMan
Copy link

@fupduck I wanted to know the status of creating a new npmjs package that points to the minified version of leaflet style editor. Is that still an item you are working on since this does resolve the IE 11 compatibility issue for leaflet style editor?

@fupduck
Copy link
Collaborator

fupduck commented Feb 14, 2020

@EvoDevMan yes - hopefully will have time this weekend

@fupduck
Copy link
Collaborator

fupduck commented Feb 14, 2020

@kyscott @EvoDevMan @pipedreamer007 now published https://www.npmjs.com/package/leaflet-styleeditor-minified

@fupduck
Copy link
Collaborator

fupduck commented Feb 14, 2020

@fupduck Memo: create option to use travis for publishing

@pipedreamer007
Copy link

@fupduck Many thanks for your hard work & excellent plug-in! I actually learned a bit looking at your project.

@fupduck
Copy link
Collaborator

fupduck commented Feb 22, 2020

@pipedreamer007 thanks this means a lot to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants