Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TestCase gets an additional boolean to remove input alignment #187

Open
sven-h opened this issue Sep 27, 2022 · 3 comments
Open

TestCase gets an additional boolean to remove input alignment #187

sven-h opened this issue Sep 27, 2022 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@sven-h
Copy link
Member

sven-h commented Sep 27, 2022

TestCase gets an additional boolean to remove from the system alignment the input alignment during evaluation.

Possible names:

  • removeInputAlignment
@sven-h sven-h self-assigned this Sep 27, 2022
@Humorloos
Copy link

My suggestion: Do not add a flag, but a new type of alignment to the testcase. This alignment specifies correspondences that should be dropped during evaluation. Instead of setting the flag when sampling an input alignment, you can then set this alignment to the input alignment

You could name this alignment BlocklistAlignment, DropAlignment, or excludeAlignment.

@janothan
Copy link
Member

I like the following three:

  • Alignment excludeAlignment
  • Alignment exclusionAlignment (to make it look less like a boolean attribute)
  • Alignment evaluationExclusionAlignment (to make it more speaking)

@janothan janothan added the enhancement New feature or request label Oct 14, 2022
@Humorloos
Copy link

I like evaluationExclusionAlignment best I think 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants