Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suites accept non-test objects #117

Open
cgay opened this issue Nov 30, 2019 · 0 comments
Open

Suites accept non-test objects #117

cgay opened this issue Nov 30, 2019 · 0 comments
Milestone

Comments

@cgay
Copy link
Member

cgay commented Nov 30, 2019

If you accidentally use the name of a normal function as a test (say, because you're reworking the testworks specification suites in the IO library) there is no error at compile time and at load time you get a cryptic error:

$ _build/bin/testworks-run --load libio-test-suite.so
Loading library libio-test-suite.so
{<simple-method>: ??? (<stream-test-info>, <buffered-stream>) => ()} is not present as a key for {<object-table>: size 1047}.
Backtrace:
  invoke-debugger:internal:dylan##1 + 0x29
  default-handler:dylan:dylan##1 + 0x15
  default-last-handler:common-dylan-internals:common-dylan##0 + 0x2f5
  error:dylan:dylan##0 + 0x26
  error:dylan:dylan##1 + 0x76
  key-missing-error:internal:dylan##0 + 0x27a
  gethash:internal:dylan + 0x8d2
  find-root-components:%testworks:testworks + 0x347
  run-test-application:testworks:testworks + 0x296

to be clear, if you have something like this:

define method test-with-input-buffer ... end;
define suite foo-suite ()
  test test-with-input-buffer;
end;
@cgay cgay added this to the Prioritization Test milestone Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant