Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURE BS5-Lightbox in default template #30

Open
jsirish opened this issue Oct 24, 2023 · 4 comments
Open

FEATURE BS5-Lightbox in default template #30

jsirish opened this issue Oct 24, 2023 · 4 comments
Assignees

Comments

@jsirish
Copy link
Member

jsirish commented Oct 24, 2023

Since Bootstrap doesn't have anything fancy for a gallery overlay, I'd like to implement the bs5-lightbox library into the default template:

https://trvswgnr.github.io/bs5-lightbox/

It requires Bootstrap 5 to run, and it leverages the Modal and Carousel classes. It plays nicely with our webpack setup as well. And the template HTML will be much less then what's in there currently, which will make it easier to maintain.

@jsirish
Copy link
Member Author

jsirish commented Oct 24, 2023

There's also awesome mixed-media implementations that I'd like to explore for other blocks, or a Media Gallery block.

@felixbec
Copy link

After further investigation, it looks like that package hasn't been updated to work with BS 5.3 and up. I will look into other packages to see what's out there.

@jsirish
Copy link
Member Author

jsirish commented Oct 25, 2023

Ah that makes sense, I was shocked I wasn't able to get it to work

@felixbec
Copy link

@jsirish https://github.com/dynamic/silverstripe-elemental-gallery/tree/feature/2023-10-26_bootstrap-modal-adjustments

I adjusted the template a bit to mimic the lightbox look/feel utilizing the default BS classes. Let me know what you think and I can create a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants