Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW resolve linkable requirement #14

Open
muskie9 opened this issue Mar 20, 2019 · 1 comment
Open

NEW resolve linkable requirement #14

muskie9 opened this issue Mar 20, 2019 · 1 comment
Assignees
Labels
help wanted Extra attention is needed question Further information is requested
Milestone

Comments

@muskie9
Copy link
Member

muskie9 commented Mar 20, 2019

As of now sheadawson/silverstripe-linkable is shown as unsupported. Determining if this is something we should pull what's used into this module, find an alternative, or figure something else out will need to happen before we get too much further with updates to this element.

@muskie9 muskie9 added help wanted Extra attention is needed question Further information is requested labels Mar 20, 2019
@muskie9 muskie9 added this to the 3.0.0 milestone Mar 20, 2019
@mak001 mak001 removed their assignment Nov 9, 2022
@NightJar
Copy link

NightJar commented Aug 5, 2024

As of now (5 years later, lol) linkable is still unsupported, but Shea does merge the occasional PR to keep it functional.
It is a bit late for this module as a refactor (fcca8ee) has already taken place (twice) to use Gorrie Coe's Silverstripe Embed module instead.

But in a cruel twist of events, Gorrie will never maintain nor merge any future PR to keep functionality (RIP 🪦).

DNA have forked embed, but maintenance does not appear to be a forefocus - I imagine doing only what is necessary to keep the module usable in their client projects (a common tale, even with my own modules).

I guess the question from here is:
Should this module go back to linkable, or pick up a fork with dubious maintenance to continue with embed?
OR remove the depenencies and consume embed/embed directly instead (upstream library of both module options)?


If the refactor and CMS upgrade stays, it should at least be tagged 3.0.0 (because breaking change). I can probably look at contributing a migration script if this is the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed question Further information is requested
Projects
None yet
Development

No branches or pull requests

5 participants