Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phabricator url including a port do not work #53

Open
Grokzen opened this issue Jan 4, 2023 · 0 comments
Open

Phabricator url including a port do not work #53

Grokzen opened this issue Jan 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Grokzen
Copy link
Contributor

Grokzen commented Jan 4, 2023

Environment

  • Python version: 3.10.x
  • Phabfive version: latest master version

Steps to Reproduce

When developing code, i stumbled upon this that when i export a development phabricator url including a port number, it fails a validation step that it should not fail on. We assume that in our regex checks that we have specified a valid URL instead of just trying the URL no matter what it is and letting it fail.

export PHAB_URL=http://phabricator.domain.tld:81/api/

Result: PHAB_URL is malformed, example: http://127.0.0.1/api/

Possible solution to this problem is to either remove the regex check, implement port checking in the regex, change from regex validation to be a requests/curl validation instead

@holmboe holmboe added the bug Something isn't working label Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants