Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Core into Core + SgitRepo for simpler logic implementation per repo and reuseability of features and functions in different commands #24

Open
Grokzen opened this issue Jan 19, 2022 · 0 comments · May be fixed by #63

Comments

@Grokzen
Copy link
Collaborator

Grokzen commented Jan 19, 2022

Right now everything is pretty much jumbled up into one place and we do all repo tracking and parsing within the Core class.

What i want to change is that we should split the logic into two classes where we make a Wrapper class around git-pythoons Repo class with our own SgitRepo class where we put most of the logic that we add that deals with the repo itself.

Then we keep most of the cli buisiness logic within the Core class as today, but we try to push down as much code as possible into SgitRepo to reduce the complexity of things.

Note here that we also want to avoid recoding same things all over that many commands already do like resetting, tracking config, custom state handling, checking if repo is dirty and so on. This belongs within SgitRepo as many different commands will want to re-use these things.

@Grokzen Grokzen linked a pull request Aug 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant