Fix CI: update tested Ruby versions, remove deprecated set-output (#44)

* update versions, set-output

* update ruby version in readme / gemspec / rubocop

* apply rubocop

* log requireMFA at info level to pass CI

Author: pirgeo

.github/workflows/checks.yaml

@@ -8,7 +8,7 @@ on:
 
 env:
   # 3.0 in quotes for https://github.com/actions/runner/issues/849
-  SUPPORTED_VERSIONS: '["3.0", 2.7, 2.6, 2.5]'
+  SUPPORTED_VERSIONS: "[ 2.7, '3.0', 3.1, 3.2]"
 
 jobs:
   supported-versions:
@@ -18,7 +18,7 @@ jobs:
     steps:
     - id: set-matrix
       run: |
-        echo "::set-output name=matrix::${{env.SUPPORTED_VERSIONS}}"
+        echo "matrix=${{env.SUPPORTED_VERSIONS}}" >> $GITHUB_OUTPUT
   unit-test:
     needs: supported-versions
     runs-on: ubuntu-latest

.rubocop.yml

@@ -1,9 +1,15 @@
 require: rubocop-rake
 
 AllCops:
-  TargetRubyVersion: 2.4
+  TargetRubyVersion: 2.7
   NewCops: enable
 
+Gemspec/DevelopmentDependencies:
+  EnforcedStyle: gemspec
+
+Gemspec/RequireMFA:
+  Severity: info
+
 Naming/MethodParameterName:
   Enabled: false
 

README.md

@@ -7,7 +7,7 @@ A fluentd output plugin for sending logs to the Dynatrace [Generic log ingest AP
 ## Requirements
 
 - An instance of fluentd >= v1.0 from which logs should be exported
-- Ruby version >= 2.4.0
+- Ruby version >= 2.7.0
 - An ActiveGate with the Generic log ingest API v2 enabled as described in the [Dynatrace documentation](https://www.dynatrace.com/support/help/shortlink/log-monitoring-log-data-ingestion)
 - A [Dynatrace API token](https://www.dynatrace.com/support/help/shortlink/api-authentication) with the `logs.ingest` (Ingest Logs) scope
 
@@ -88,7 +88,7 @@ An full example demonstrating how to set up Fluentd on Kubernetes and export log
 
 ## Development
 
-`fluent-plugin-dynatrace` supports Ruby versions `>= 2.4.0` but it is recommended that at least `2.7.2` is used for development. Ruby versions can be managed with tools like [chruby](https://github.com/postmodern/chruby) or [rbenv](https://github.com/rbenv/rbenv).
+`fluent-plugin-dynatrace` supports Ruby versions `>= 2.7.0` but it is recommended that at least `2.7.2` is used for development. Ruby versions can be managed with tools like [chruby](https://github.com/postmodern/chruby) or [rbenv](https://github.com/rbenv/rbenv).
 
 ### Install Dependencies
 

fluent-plugin-dynatrace.gemspec

@@ -22,11 +22,12 @@ Gem::Specification.new do |gem|
 
   gem.require_paths = ['lib']
 
-  gem.required_ruby_version = '>= 2.4.0'
+  gem.required_ruby_version = '>= 2.7.0'
 
   gem.add_runtime_dependency 'fluentd', ['>= 0.14.22', '< 2']
   gem.add_development_dependency 'bundler', ['>= 2', '<3']
-  gem.add_development_dependency 'rake', '13.0.3'
-  gem.add_development_dependency 'rubocop', '1.9.1'
-  gem.add_development_dependency 'rubocop-rake', '0.5.1'
+  gem.add_development_dependency 'rake', '13.1.0'
+  gem.add_development_dependency 'rubocop', '1.59.0'
+  gem.add_development_dependency 'rubocop-rake', '0.6.0'
+  gem.add_development_dependency 'test-unit', '3.6.1'
 end

lib/fluent/plugin/out_dynatrace.rb

@@ -31,8 +31,8 @@ class DynatraceOutput < Output
       # Configurations
       desc 'The full URL of the Dynatrace log ingestion endpoint, e.g. https://my-active-gate.example.com/api/logs/ingest'
       config_param :active_gate_url, :string
-      desc 'The API token to use to authenticate requests to the log ingestion endpoint. '\
-           'Must have logs.ingest (Ingest Logs) scope. '\
+      desc 'The API token to use to authenticate requests to the log ingestion endpoint. ' \
+           'Must have logs.ingest (Ingest Logs) scope. ' \
            'It is recommended to limit scope to only this one.'
       config_param :api_token, :string, secret: true
 

test/integration_dtcluster/plugin_dt_test.rb

@@ -28,15 +28,15 @@ class TestPluginDynatraceIntegration < Test::Unit::TestCase
 
   def active_gate_url
     # Expect an active gate url in the format https://127.0.0.1:9999/e/abc12345
-    url = ENV['ACTIVE_GATE_URL']
+    url = ENV.fetch('ACTIVE_GATE_URL', nil)
     raise 'expected environment variable ACTIVE_GATE_URL' if url.nil?
 
     url
   end
 
   def api_token
     # Expect an API token with `logs.ingest` (Ingest Logs) and `logs.read` (Read Logs) scope
-    token = ENV['API_TOKEN']
+    token = ENV.fetch('API_TOKEN', nil)
     raise 'expected environment variable API_TOKEN' if token.nil?
 
     token
@@ -97,7 +97,7 @@ def try_get_log(nonce)
     body = JSON.parse(res.body)
     results = body['results']
 
-    return false if results.length.zero?
+    return false if results.empty?
 
     assert_equal(results[0]['content'], nonce)
     true