[Question] Integrate ESP-32

[chriamue]

Hi, I'm trying to implement dp3t advertisements on an esp32 for debugging purpose:
https://github.com/chriamue/esp32-dp3t
I used some of your repos code.
What do you think would be best proceeding to back integrate changed code into this repo?
ESP32 subfolder, #ifdefs for esp32 or just keep it in extra git repo?

[danielinux]

Hi,I don't think it's a good idea to host your ESP32 version in this repo, which is targeting a different platform.
I guess the only shared code so far is the modified dp3t? If you want to keep your code in sync you should refer to that (https://github.com/dyne/pangolin)

After a quick look, things concern me about your repository though:

• I see you "downgraded" your dp3t code to use mbedTLS, I am wondering if this is a good idea at all in terms of performance and security? The claim of pangolin being "fastest" is compromised...

• Where is all the code linked to the platform? I see your repo has a GPL license, but I am not sure that all the dependencies are shown (e.g. all the code added under the "arduino" hood, or all the bluetooth drivers from Espressif, are all the sources available anywhere?)

Edit: ignore second question, I see all the sources are available under GPL here:
https://github.com/espressif/arduino-esp32/

Thanks,

/d

[jaromil]

Hi! Danielinux is right in pointing you to the Secret Pangolin which would be the best place to integrate your approach, perhaps documenting the calls.

This project "decode-proximity-hw" targets explicitly a range of hardware we chose, but the Secret Pangolin is a component we are developing stand-alone to facilitate you and anyone else to port deterministic setups of DP3T that are well compatible with present and upcoming standards.

I will link your effort from there, but with a caveat as your are using mbedTLS which is not passing all FIPS tests and was officially dropped by ARM, hence putting at risk determinism. I understand yours is an experiment for now: we recommend to adopt as soon as possible a library that aligns with FIPS and NIST test suites for the sake of compatibility and peace of mind.

At last please note that both dp3t and this project are licensed as AGPLv3 to better protect our rights as software artisans, but we are of course very open to discuss with anyone interested about other licensing needs, exceptions etc. that should not be a problem, whenever we want to get in touch.

Ciao!