Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No compatible version for Angular 9 #35

Open
akaustav opened this issue Jun 1, 2021 · 2 comments · May be fixed by #36
Open

No compatible version for Angular 9 #35

akaustav opened this issue Jun 1, 2021 · 2 comments · May be fixed by #36

Comments

@akaustav
Copy link

akaustav commented Jun 1, 2021

Issue Summary

We are unable to update our private Angular 9.1.3 repository to Angular version 10 or higher at the moment until a few more months. Meanwhile, there does not seem to be a compatible version of ngx-linky with Angular version 9. Please publish a version of ngx-linky which is compatible with Angular 9.

[email protected] was compatible with Angular versions 4 thru 8.
[email protected] seems to be compatible with Angular 10 and higher.
As a result, the yarn install or yarn add commands keeps throwing the following warnings in our project running Angular 9:

With ngx-linky version 2.2.0

Command:
yarn add ngx-linky@^2.2.0

Warnings:

warning " > [email protected]" has incorrect peer dependency "@angular/common@^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0".
warning " > [email protected]" has incorrect peer dependency "@angular/core@^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0".

With ngx-linky version 3.0.0

Command:
yarn add ngx-linky@^3.0.0

Warnings:

warning " > [email protected]" has incorrect peer dependency "@angular/common@>=10.0.0".
warning " > [email protected]" has incorrect peer dependency "@angular/core@>=10.0.0".
@akaustav
Copy link
Author

akaustav commented Jun 1, 2021

Looks like yarn reads the peerDependencies object from the package.json file:

From ngx-linky tag v2.2.0:

"peerDependencies": {
"@angular/common": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
"@angular/core": "^4.0.0 || ^5.0.0 || ^6.0.0 || ^7.0.0 || ^8.0.0",
"autolinker": "^3.0.0"
}

From ngx-linky tag v3.0.0:

"peerDependencies": {
"@angular/common": ">=10.0.0",
"@angular/core": ">=10.0.0",
"autolinker": ">=3.0.0"
}

@akaustav
Copy link
Author

akaustav commented Jun 1, 2021

If it helps, both versions 2.2.0 and 3.0.0 of ngx-linky work for our use-cases within our repo running Angular 9.1.3.

@akaustav akaustav linked a pull request Jun 1, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant