Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using DotNetZip 1.16.0 #1079

Open
CWolffIF opened this issue Dec 14, 2024 · 3 comments
Open

Using DotNetZip 1.16.0 #1079

CWolffIF opened this issue Dec 14, 2024 · 3 comments
Labels
Bug Reactive.XAF eXpandFrameowrk/DevExpress.XAF project

Comments

@CWolffIF
Copy link
Member

Hi,

I think eXpandIO/24.1.701 is using DotNetZip 1.16.0 and there is no newer Version.

DotNetZip Directory Traversal vulnerability.
https://github.com/advisories/GHSA-xhg6-9j5j-w4vf

Can you change it?

@CWolffIF CWolffIF added Bug Reactive.XAF eXpandFrameowrk/DevExpress.XAF project labels Dec 14, 2024
@apobekiaris
Copy link
Member

I did not checked yet how many resources needed to this task, however I want to give u my perspective about those vulnerability warnings. In short they are endless and can lead to spent a great number of resources to constantly upgrade all these packages we use, not to say that each upgrade may cost us another problem.

So, my strategy is not to change anything unless there is a reason and at least a basic research. Because yes there is a vunerability there but does it affect us? does it affect your projects? in what level?

Please provide details and then happy to put some time to see what's going on there.

Note this package is only used from the IO module (Windows) and to upgrade it to the System.IO.Compression it requires the following steps

  1. Create sample
  2. Upgrade the code
  3. Test the code

they may look simple but timing wise it can take from a few hrs to a full day depending on what u find in your way.

@CWolffIF
Copy link
Member Author

In principle I agree with you.
That´s why we try to avoid too many nugets, espacially if the function can be used by standard system. We use Devexpress as base system. Devexpress is maintened. eXpandFramework is based on Devexpress. Can ZIP/Compression functions be used by Devexpress, so that DotNetZip is not needed?

@apobekiaris
Copy link
Member

eXpandFramework is based on Devexpress

not entirely true, eXpand uses packages from all nugget ecosystem. As I said there is no clarification where this vunerability affects u and making changes has a cost. When the IO module was authored there was no build in support so I chose this external lib

@apobekiaris apobekiaris removed their assignment Jan 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Reactive.XAF eXpandFrameowrk/DevExpress.XAF project
Projects
None yet
Development

No branches or pull requests

2 participants