Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PSR 0, 1 and 2 compliance... #1

Open
vpassapera opened this issue Nov 16, 2012 · 3 comments
Open

PSR 0, 1 and 2 compliance... #1

vpassapera opened this issue Nov 16, 2012 · 3 comments
Assignees

Comments

@vpassapera
Copy link

I noticed in certain areas (https://github.com/easy-cloud/acl/blob/master/src/Controller/GroupController.php first place I looked....) you are not following all the PSR standards. While it is not required, it is recommended if you seek adoption in enterprise projects. (Just my two cents).

@tawfekov
Copy link

and could you please provide some tests .
thanks

@TNAJanssen
Copy link
Member

Sorry for my late reaction(was busy), i'm working on a couple of other modules and afterwards i will improve this one. I build this module in less then a week so it can be that there are some errors or missing standards.

I also made this project open so that other people can help me with improving it further.

@TNAJanssen
Copy link
Member

PSR-0 - Done

@ghost ghost assigned TNAJanssen Dec 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants