fix: lint rule ENUM_ZERO_VALUE_PREFIX) (#90)

hound672 · web-flow · commit 8872ccf39a24 · 2024-08-21T14:12:42.000+03:00
diff --git a/easyp.yaml b/easyp.yaml
@@ -54,7 +54,7 @@ lint:
     - RPC_NO_CLIENT_STREAMING
     - RPC_NO_SERVER_STREAMING
 
-  enum_zero_value_suffix: _NONE
+  enum_zero_value_suffix: NONE
 
   service_suffix: API
 
diff --git a/internal/lint/rules/enum_zero_value_suffix.go b/internal/lint/rules/enum_zero_value_suffix.go
@@ -23,7 +23,7 @@ func (e *EnumZeroValueSuffix) Validate(protoInfo lint.ProtoInfo) ([]lint.Issue,
 
 	for _, enum := range protoInfo.Info.ProtoBody.Enums {
 		zeroValue := enum.EnumBody.EnumFields[0]
-		if zeroValue.Ident != pascalToUpperSnake(enum.EnumName)+e.Suffix {
+		if zeroValue.Ident != pascalToUpperSnake(enum.EnumName)+"_"+e.Suffix {
 			res = lint.AppendIssue(
 				res,
 				e,
diff --git a/internal/lint/rules/enum_zero_value_suffix_test.go b/internal/lint/rules/enum_zero_value_suffix_test.go
@@ -75,7 +75,7 @@ func TestEnumZeroValueSuffix_Validate(t *testing.T) {
 			r, protos := start(t)
 
 			rule := rules.EnumZeroValueSuffix{
-				Suffix: "_NONE",
+				Suffix: "NONE",
 			}
 			issues, err := rule.Validate(protos[tc.fileName])
 			r.ErrorIs(err, tc.wantErr)

Original file line number	Diff line number	Diff line change
`@@ -75,7 +75,7 @@ func TestEnumZeroValueSuffix_Validate(t *testing.T) {`
`75`	`75`	`r, protos := start(t)`
`76`	`76`
`77`	`77`	`rule := rules.EnumZeroValueSuffix{`
`78`		`- Suffix: "_NONE",`
	`78`	`+ Suffix: "NONE",`
`79`	`79`	`}`
`80`	`80`	`issues, err := rule.Validate(protos[tc.fileName])`
`81`	`81`	`r.ErrorIs(err, tc.wantErr)`