eslint: switch to flat configuration #5282

BacLuc · 2024-06-02T11:01:36Z

Eslint 9 uses a new configuration format by default (called "flat configuration"). So this PR would need some config changes before we can upgrade to eslint9.

For Nuxt, some further details are described here:
https://eslint.nuxt.com/guide/faq#package-disambiguation
https://eslint.nuxt.com/packages/module

And here is a eslint migration guide for the new config format:
https://eslint.org/docs/latest/use/configure/migration-guide

Originally posted by @usu in #5155 (comment)

Also, we shouldn't need to add @typescript-eslint/eslint-plugin to the dev dependencies anymore.

BacLuc · 2024-06-02T11:04:25Z

Proposal to resolve this:

switch to new format for all modules
I would do this first, because i did not get the nuxt eslint helper modules to support both
Update to eslint 9

manuelmeister · 2024-06-04T19:23:14Z

Core Meeting Decision

We individually switch the format for each module
Update to eslint 9

With node_modules/.bin/eslint --print-config specs/login.cy.js > eslint-config-js.json That we are sure that the config did not change during the migration. Issue: ecamp#5282

The config migrator needs the configuration to be in a separate file. https://eslint.org/blog/2024/05/eslint-configuration-migrator/ Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Remove the options from the call to eslint which are not supported anymore in the package.json. The resulting schema of the command node_modules/.bin/eslint --print-config specs/login.cy.js > eslint-config-js.json is different. But diffing only the rules seemed to look the same. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Add .mjs files to the prettier pattern that the eslint.config.mjs is also prettied. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Remove the options from the call to eslint which are not supported anymore in the package.json. Also run mjs files through the prettier. Issue: ecamp#5282

Was only needed for the migration Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed npm install -D -E globals @eslint/js @eslint/eslintrc @eslint/compat Add paths from the .gitignore file to the ignored patterns. Add data, dist and public/twemoji explicitly because that did not work with the includeIgnoreFile. Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Ignore common, .nuxt and .output explicitly, because it did not work with includeIgnoreFile. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Add .mjs files to the prettier pattern that the eslint.config.mjs is also prettied. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

The . after the eslint command is important, else it lints nothing. Explicitly exclude the generated files, ignoring it via the .gitignored files did not work. Issue: ecamp#5282

The . after the eslint command is important, else it lints nothing. Ignore the data directory explicitly. Add eslint-parser and set languageOptions.ecmaVersion to 2022, else the import.meta above leads to a lint error. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed npm install -D -E globals @eslint/js @eslint/eslintrc @eslint/compat Add paths from the .gitignore file to the ignored patterns. Add data, dist and public/twemoji explicitly because that did not work with the includeIgnoreFile. Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Add .mjs files to the prettier pattern that the eslint.config.mjs is also prettied. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Issue: ecamp#5282

Using npx @eslint/migrate-config .eslintrc.json Then add the additional packages needed (@eslint/compat, globals, @eslint/eslintrc, @eslint/js) Add paths from the .gitignore file to the ignored patterns. Also lint .ts files with eslint (this seems not to be the default). Remove the options from the call to eslint which are not supported anymore in the package.json. Ignore common, .nuxt and .output explicitly, because it did not work with includeIgnoreFile. Issue: ecamp#5282

BacLuc added Meeting Discuss Am nächsten Core-Meeting besprechen type: Frontend type: Print labels Jun 2, 2024

manuelmeister removed the Meeting Discuss Am nächsten Core-Meeting besprechen label Jun 4, 2024

BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Aug 2, 2024

e2e: dump current eslint config

0f552ec

With node_modules/.bin/eslint --print-config specs/login.cy.js > eslint-config-js.json That we are sure that the config did not change during the migration. Issue: ecamp#5282

BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Aug 2, 2024

e2e: move eslint config to .eslintrc.json

ec9d57f

The config migrator needs the configuration to be in a separate file. https://eslint.org/blog/2024/05/eslint-configuration-migrator/ Issue: ecamp#5282

BacLuc added a commit to BacLuc/ecamp3 that referenced this issue Aug 12, 2024

pdf: delete eslint-config-(js,vue).json again

037d15d

Was only needed for the migration Issue: ecamp#5282

BacLuc self-assigned this Aug 13, 2024

BacLuc mentioned this issue Aug 13, 2024

pdf: fix migrate eslint config #5713

Merged

BacLuc mentioned this issue Aug 13, 2024

e2e: fix migrate eslint config #5714

Merged

BacLuc closed this as completed Aug 21, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

eslint: switch to flat configuration #5282

eslint: switch to flat configuration #5282

BacLuc commented Jun 2, 2024 •

edited

Loading

BacLuc commented Jun 2, 2024

manuelmeister commented Jun 4, 2024

eslint: switch to flat configuration #5282

eslint: switch to flat configuration #5282

Comments

BacLuc commented Jun 2, 2024 • edited Loading

BacLuc commented Jun 2, 2024

manuelmeister commented Jun 4, 2024

Core Meeting Decision

BacLuc commented Jun 2, 2024 •

edited

Loading