Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clicking on a (finished) job status circle should take me to that job's results #643

Closed
sschuberth opened this issue Jul 9, 2024 · 2 comments
Closed

Clicking on a (finished) job status circle should take me to that job's results #643

sschuberth opened this issue Jul 9, 2024 · 2 comments
Assignees
@Etsija
Labels
enhancement New feature or request ui Issues related to the UI.

Comments

@sschuberth
Copy link
Contributor

For example clicking on the analyzer job circle at

image

should take me straight to

image
@sschuberth sschuberth added enhancement New feature or request ui Issues related to the UI. labels Jul 9, 2024
@Etsija
Copy link
Contributor

Etsija commented Jul 12, 2024

Note to myself: this could probably be used.
https://tanstack.com/router/latest/docs/framework/react/guide/navigation#hash-links

@Etsija Etsija self-assigned this Jul 12, 2024
@sschuberth sschuberth changed the title Clicking on a (finish) job status circle should take me to that jobs results Clicking on a (finished) job status circle should take me to that job's results Jul 12, 2024
@Etsija Etsija mentioned this issue Jul 15, 2024
Closed
10 tasks
@sschuberth sschuberth mentioned this issue Aug 8, 2024
Closed
@Etsija Etsija mentioned this issue Aug 27, 2024
Open
12 tasks
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Aug 28, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
2f63e2e 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

Resolves eclipse-apoapsis#643.

Signed-off-by: Jyrki Keisala <[email protected]>
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Aug 28, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
9ff6480 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

Resolves eclipse-apoapsis#643.

Signed-off-by: Jyrki Keisala <[email protected]>
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Aug 29, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
e67640f 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

Resolves eclipse-apoapsis#643.

Signed-off-by: Jyrki Keisala <[email protected]>
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Aug 29, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
01749fd 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

Resolves eclipse-apoapsis#643.

Signed-off-by: Jyrki Keisala <[email protected]>
Etsija added a commit to doubleopen-project/ort-server that referenced this issue Aug 29, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
3d833db 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

NOTE: The id's that mark the position in the scrolling job configuration
page need a `scroll-mt-16` class to compensate for the UI's header,
otherwise clicking a job traffic light would result to the page opening
such that the job configuration is partly scrolled behind the header.

Resolves eclipse-apoapsis#643.

Signed-off-by: Jyrki Keisala <[email protected]>
github-merge-queue bot pushed a commit that referenced this issue Aug 29, 2024
@Etsija
feat(ui): Clicking traffic lights takes to corr. job configuration
f3592fd 
Add section anchors to the job configuration sub-page of the ORT run
details page. Clicking a traffic light of a job in the repository
index page takes the user to the corresponding section of the job
configuration page.

NOTE: The id's that mark the position in the scrolling job configuration
page need a `scroll-mt-16` class to compensate for the UI's header,
otherwise clicking a job traffic light would result to the page opening
such that the job configuration is partly scrolled behind the header.

Resolves #643.

Signed-off-by: Jyrki Keisala <[email protected]>
@Etsija
Copy link
Contributor

Etsija commented Aug 29, 2024

Implemented with #917.

@Etsija Etsija closed this as completed Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Etsija Etsija

Labels
enhancement New feature or request ui Issues related to the UI.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sschuberth @Etsija