Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to using '@types/vscode' rather than 'vscode' #64

Closed
Kummallinen opened this issue Apr 21, 2022 · 1 comment
Closed

Migrate to using '@types/vscode' rather than 'vscode' #64

Kummallinen opened this issue Apr 21, 2022 · 1 comment

Comments

@Kummallinen
Copy link
Contributor

The vscode package was split into '@types/vscode' & '@vscode/test-electron', see https://code.visualstudio.com/updates/v1_36#_splitting-vscode-package-into-typesvscode-and-vscodetest

Using '@types/vscode' provides better build compatibility when behind strict corporate firewalls as it does not need to download vscode.d.ts as a separate step.

Kummallinen added a commit to Kummallinen/cdt-gdb-vscode that referenced this issue Apr 21, 2022
@jonahgraham
Copy link
Contributor

Thanks @Kummallinen - this looks like a good idea. It is one of the updates that isn't caught with standard tools.

jonahgraham pushed a commit that referenced this issue Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants